Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src/doc/en/installation/source.rst: Add section on upgrading using worktrees #37411

Merged
merged 3 commits into from
Mar 31, 2024
Merged

src/doc/en/installation/source.rst: Add section on upgrading using worktrees #37411

merged 3 commits into from
Mar 31, 2024

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Feb 21, 2024 •
edited
Loading

As discussed in https://groups.google.com/g/sage-devel/c/5kmxaw105lg/m/neVlNrGVAAAJ, we add a new section to the installation manual:

This complements the existing section on use of git worktree in the developer's guide. It is written for use by the general user base.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@mkoeppe mkoeppe self-assigned this Feb 21, 2024
@github-actions GitHub Actions
Copy link

Documentation preview for this PR (built with commit 8766c9b; changes) is ready! 🎉

yyyyx4
yyyyx4 approved these changes Feb 23, 2024
View reviewed changes
Copy link
Member

@yyyyx4 yyyyx4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is definitely helpful to a nonzero number of people (including myself) and should be uncontroversial since it's only a documentation change.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 23, 2024

Thanks for the review!

@mkoeppe mkoeppe added this to the sage-10.3 milestone Mar 5, 2024
@mkoeppe mkoeppe removed this from the sage-10.3 milestone Mar 20, 2024
@vbraun vbraun merged commit 41c4160 into sagemath:develop Mar 31, 2024
21 checks passed
@mkoeppe mkoeppe added this to the sage-10.4 milestone Mar 31, 2024
@mkoeppe mkoeppe deleted the doc_git_worktree branch April 12, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yyyyx4 yyyyx4 yyyyx4 approved these changes

@jhpalmieri jhpalmieri Awaiting requested review from jhpalmieri

@yuan-zhou yuan-zhou Awaiting requested review from yuan-zhou

@grhkm21 grhkm21 Awaiting requested review from grhkm21

Assignees

@mkoeppe mkoeppe

Labels
c: documentation t: enhancement
Projects
None yet
Milestone
sage-10.4
Development

Successfully merging this pull request may close these issues.
3 participants
@mkoeppe @yyyyx4 @vbraun