Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

formal deprecation of old CommutativeAlgebra class #37464

Merged
merged 1 commit into from
Mar 31, 2024
Merged

formal deprecation of old CommutativeAlgebra class #37464

merged 1 commit into from
Mar 31, 2024

Conversation

fchapoton
Copy link
Contributor

as another step towards the general use of Parent, Element and categories

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

@github-actions GitHub Actions
Copy link

Documentation preview for this PR (built with commit 057e73d; changes) is ready! 🎉

mkoeppe
mkoeppe approved these changes Feb 26, 2024
View reviewed changes
Copy link
Member

@mkoeppe mkoeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vbraun vbraun merged commit 6ac7a93 into sagemath:develop Mar 31, 2024
18 of 20 checks passed
@mkoeppe mkoeppe added this to the sage-10.4 milestone Mar 31, 2024
@fchapoton fchapoton deleted the deprecate_CommutativeAlgebra branch April 1, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkoeppe mkoeppe mkoeppe approved these changes

Assignees
No one assigned
Labels
c: commutative algebra p: minor / 4 t: refactoring
Projects
None yet
Milestone
sage-10.4
Development

Successfully merging this pull request may close these issues.
4 participants
@fchapoton @mkoeppe @vbraun @grhkm21