Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enrich the test_karatsuba failure message with explicit elements #37561

Merged
merged 3 commits into from
Mar 31, 2024
Merged

enrich the test_karatsuba failure message with explicit elements #37561

merged 3 commits into from
Mar 31, 2024

Conversation

fchapoton
Copy link
Contributor

To help debug the random failure in test_karatsuba_multiplication, let us have a more precise error message in case of failure there.

cf #35715

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.

@fchapoton fchapoton requested a review from mantepse March 7, 2024 10:01
mantepse
mantepse approved these changes Mar 7, 2024
View reviewed changes
Copy link
Collaborator

@mantepse mantepse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK - I guess we will be able to figure out the threshold.

@GiacomoPope
Copy link
Contributor

Would be good to get this merged ASAP to get to the bottom of the error

@github-actions GitHub Actions
Copy link

Documentation preview for this PR (built with commit 9f15505; changes) is ready! 🎉

@vbraun vbraun merged commit 644ba54 into sagemath:develop Mar 31, 2024
12 of 13 checks passed
@mkoeppe mkoeppe added this to the sage-10.4 milestone Mar 31, 2024
@fchapoton fchapoton deleted the enrich_test_kara_message branch April 1, 2024 07:32
@GiacomoPope GiacomoPope mentioned this pull request Apr 10, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mantepse mantepse mantepse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
sage-10.4
Development

Successfully merging this pull request may close these issues.
5 participants
@fchapoton @GiacomoPope @mantepse @vbraun @mkoeppe