build/pkgs/cython: Update to 3.0.10 #37584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Loads of stuff like in various doctests. |
Yes, this is what causes #37560 and is worked around (not fixed) in #37583. I have a patch almost ready that fixes the issues for good, as in I can build sagemath with 0 warnings. This needs:
Note that the cython patch I cited above is necessary to get a warning free compilation. With stock 3.0.9, we have ~40k lines that give one warning when you add With all the above patches there are just 136 cython warnings left in total, of which 108 are |
|
To get rid of the warnings for good we need: |
|
Do you know if this cython fix is being backported to 3.0.10? |
|
I've added these items to "Dependencies" above. |
Yes, the commit I linked to is the backported one in the 3.0.x branch (already merged). No idea when they'll release 3.0.10. |
|
OK, thanks. I'll put it here on the branch. |
mkoeppe
changed the title
|
Also note that for now nothing changes behaviour, so these are not really dependencies but "nice to have". The only reason having 3.0.9+patch is nice is because it makes #37667 look better. In the sense that it shows that the Note that there is no change of behaviour. All of this may seem a bit silly: why bother with the noexcept lines if cython is able to infer them right? Well, that's only because we are in I think a good strategy for us is to make sure we fix everything, and once we are sure to build the whole sagemath without a single warning related to |
|
Yes, I agree that this is a good strategy. |
|
cython 3.0.10 is released, includes the noexcept patch, and works fine. fwiw, I'm on cypari 2.1.5 and memory_allocator 0.1.4 without any trouble at all. |
mkoeppe
changed the title
|
Documentation preview for this PR (built with commit 69ac439; changes) is ready! 🎉 |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Apr 11, 2024
<!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> These upgrades are for - sagemath#37584 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#37665 Reported by: Matthias Köppe Reviewer(s):
5 tasks
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 5, 2024
<!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> - Depends on sagemath#37583 (merged here) - Depends on sagemath#37665 (merged here) - Depends on sagemath#37667 (merged here) - Depends on cython/cython@4e9f7307312881111b6 f56279a83812a2309cd16 (see cython/cython#6087 (comment)) (carried here as a patch) - Depends on sagemath#37646 (merged here for convenience) URL: sagemath#37584 Reported by: Matthias Köppe Reviewer(s):
|
Thanks, Volker. |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 9, 2024
<!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> - Depends on sagemath#37583 (merged here) - Depends on sagemath#37665 (merged here) - Depends on sagemath#37667 (merged here) - Depends on cython/cython@4e9f7307312881111b6 f56279a83812a2309cd16 (see cython/cython#6087 (comment)) (carried here as a patch) - Depends on sagemath#37646 (merged here for convenience) URL: sagemath#37584 Reported by: Matthias Köppe Reviewer(s):
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 11, 2024
<!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> - Depends on sagemath#37583 (merged here) - Depends on sagemath#37665 (merged here) - Depends on sagemath#37667 (merged here) - Depends on cython/cython@4e9f7307312881111b6 f56279a83812a2309cd16 (see cython/cython#6087 (comment)) (carried here as a patch) - Depends on sagemath#37646 (merged here for convenience) URL: sagemath#37584 Reported by: Matthias Köppe Reviewer(s):
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 12, 2024
<!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> - Depends on sagemath#37583 (merged here) - Depends on sagemath#37665 (merged here) - Depends on sagemath#37667 (merged here) - Depends on cython/cython@4e9f7307312881111b6 f56279a83812a2309cd16 (see cython/cython#6087 (comment)) (carried here as a patch) - Depends on sagemath#37646 (merged here for convenience) URL: sagemath#37584 Reported by: Matthias Köppe Reviewer(s):
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Checklist
⌛ Dependencies
cypari22.1.5,memory_allocator0.1.4 #37665 (merged here)legacy_implicit_noexcept=Truecython/cython#6087 (comment)) (carried here as a patch)