matrix, Graph.incidence_matrix, LinearMatroid.representation: Support constructing Hom(CombinatorialFreeModule) elements
#37692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ys, check consistency
added 6 commits
March 29, 2024 15:17
…hods _repr_matrix, _ascii_art_matrix, _unicode_art_matrix
mkoeppe
changed the title
matrix: Support constructing Hom(CombinatorialFreeModule) elementsmatrix, Graph.incidence_matrix: Support constructing Hom(CombinatorialFreeModule) elements
mkoeppe
changed the title
matrix, Graph.incidence_matrix: Support constructing Hom(CombinatorialFreeModule) elementsmatrix, Graph.incidence_matrix, LinearMatroid.representation: Support constructing Hom(CombinatorialFreeModule) elements
|
Documentation preview for this PR (built with commit 3e71e20; changes) is ready! 🎉 |
|
Merged the latest version of the dependency #37514. Any remaining concerns, or may I set to "positive review"? |
|
None from me. |
|
Thanks! |
|
doesn't work, ci fails |
|
All tests pass. Failure of "test modularized distributions" is unrelated. |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Apr 28, 2024
…representation`: Support constructing `Hom(CombinatorialFreeModule)` elements
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->
We use morphisms of `CombinatorialFreeModule`s (each of which has a
distinguished finite or enumerated basis indexed by arbitrary objects)
as matrices whose rows and columns are indexed by arbitrary objects
(`row_keys`, `column_keys`).
Example:
```
sage: M = matrix([[1,2,3], [4,5,6]],
....: column_keys=['a','b','c'], row_keys=['u','v']);
M
Generic morphism:
From: Free module generated by {'a', 'b', 'c'} over Integer
Ring
To: Free module generated by {'u', 'v'} over Integer Ring
```
Example application done here on the PR: The incidence matrix of a graph
or digraph. Returning it as a morphism instead of a matrix has the
benefit of keeping the vertices and edges with the result. This new
behavior is activated by special values for the existing parameters
`vertices` and `edges`.
```
sage: D12 = posets.DivisorLattice(12).hasse_diagram()
sage: phi_VE = D12.incidence_matrix(vertices=True,
edges=True); phi_VE
Generic morphism:
From: Free module generated by
{(1, 2), (1, 3), (2, 4), (2, 6), (3, 6), (4, 12),
(6, 12)}
over Integer Ring
To: Free module generated by {1, 2, 3, 4, 6, 12} over
Integer Ring
sage: print(phi_VE._unicode_art_matrix())
(1, 2) (1, 3) (2, 4) (2, 6) (3, 6) (4, 12)
(6, 12)
1⎛ -1 -1 0 0 0 0
0⎞
2⎜ 1 0 -1 -1 0 0
0⎟
3⎜ 0 1 0 0 -1 0
0⎟
4⎜ 0 0 1 0 0 -1
0⎟
6⎜ 0 0 0 1 1 0
-1⎟
12⎝ 0 0 0 0 0 1
1⎠
```
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
- Depends on sagemath#37607
- Depends on sagemath#37514
- Depends on sagemath#37606
- Depends on sagemath#37646
URL: sagemath#37692
Reported by: Matthias Köppe
Reviewer(s): gmou3
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 9, 2024
This follows the merging of sagemath#37692 and it enables the (re-)feeding of a linear matroid's morphism representation into the `Matroid` constructor. Example: ``` sage: M = matroids.catalog.Fano() sage: A = M.representation(order=True); A Generic morphism: From: Free module generated by {'a', 'b', 'c', 'd', 'e', 'f', 'g'} over Finite Field of size 2 To: Free module generated by {0, 1, 2} over Finite Field of size 2 sage: Matroid(A) Binary matroid of rank 3 on 7 elements, type (3, 0) ``` URL: sagemath#37940 Reported by: gmou3 Reviewer(s): gmou3, Matthias Köppe, Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 11, 2024
This follows the merging of sagemath#37692 and it enables the (re-)feeding of a linear matroid's morphism representation into the `Matroid` constructor. Example: ``` sage: M = matroids.catalog.Fano() sage: A = M.representation(order=True); A Generic morphism: From: Free module generated by {'a', 'b', 'c', 'd', 'e', 'f', 'g'} over Finite Field of size 2 To: Free module generated by {0, 1, 2} over Finite Field of size 2 sage: Matroid(A) Binary matroid of rank 3 on 7 elements, type (3, 0) ``` URL: sagemath#37940 Reported by: gmou3 Reviewer(s): gmou3, Matthias Köppe, Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 11, 2024
…x}`: Support constructing `End(CombinatorialFreeModule)` elements
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->
This is a follow-up after
- sagemath#37692
... to cover a few more methods. The methods can now create
endomorphisms of free modules whose bases are indexed by the vertices.
To help with this, we make the `matrix` constructor a bit more flexible.
This is also preparation for making the spectral graph theory methods
ready for `CombinatorialFreeModule`:
- sagemath#37943
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
URL: sagemath#37955
Reported by: Matthias Köppe
Reviewer(s): David Coudert, Matthias Köppe
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 12, 2024
This follows the merging of sagemath#37692 and it enables the (re-)feeding of a linear matroid's morphism representation into the `Matroid` constructor. Example: ``` sage: M = matroids.catalog.Fano() sage: A = M.representation(order=True); A Generic morphism: From: Free module generated by {'a', 'b', 'c', 'd', 'e', 'f', 'g'} over Finite Field of size 2 To: Free module generated by {0, 1, 2} over Finite Field of size 2 sage: Matroid(A) Binary matroid of rank 3 on 7 elements, type (3, 0) ``` URL: sagemath#37940 Reported by: gmou3 Reviewer(s): gmou3, Matthias Köppe, Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 12, 2024
…x}`: Support constructing `End(CombinatorialFreeModule)` elements
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->
This is a follow-up after
- sagemath#37692
... to cover a few more methods. The methods can now create
endomorphisms of free modules whose bases are indexed by the vertices.
To help with this, we make the `matrix` constructor a bit more flexible.
This is also preparation for making the spectral graph theory methods
ready for `CombinatorialFreeModule`:
- sagemath#37943
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
URL: sagemath#37955
Reported by: Matthias Köppe
Reviewer(s): David Coudert, Matthias Köppe
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 12, 2024
This follows the merging of sagemath#37692 and it enables the (re-)feeding of a linear matroid's morphism representation into the `Matroid` constructor. Example: ``` sage: M = matroids.catalog.Fano() sage: A = M.representation(order=True); A Generic morphism: From: Free module generated by {'a', 'b', 'c', 'd', 'e', 'f', 'g'} over Finite Field of size 2 To: Free module generated by {0, 1, 2} over Finite Field of size 2 sage: Matroid(A) Binary matroid of rank 3 on 7 elements, type (3, 0) ``` URL: sagemath#37940 Reported by: gmou3 Reviewer(s): gmou3, Matthias Köppe, Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 12, 2024
…x}`: Support constructing `End(CombinatorialFreeModule)` elements
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->
This is a follow-up after
- sagemath#37692
... to cover a few more methods. The methods can now create
endomorphisms of free modules whose bases are indexed by the vertices.
To help with this, we make the `matrix` constructor a bit more flexible.
This is also preparation for making the spectral graph theory methods
ready for `CombinatorialFreeModule`:
- sagemath#37943
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
URL: sagemath#37955
Reported by: Matthias Köppe
Reviewer(s): David Coudert, Matthias Köppe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use morphisms of
CombinatorialFreeModules (each of which has a distinguished finite or enumerated basis indexed by arbitrary objects) as matrices whose rows and columns are indexed by arbitrary objects (row_keys,column_keys).Example:
Example application done here on the PR: The incidence matrix of a graph or digraph. Returning it as a morphism instead of a matrix has the benefit of keeping the vertices and edges with the result. This new behavior is activated by special values for the existing parameters
verticesandedges.📝 Checklist
⌛ Dependencies
MatrixSpace: Support constructingHom(CombinatorialFreeModule)#37514