-
-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added some documentation in the developer's guide regarding deprecation #37807
Conversation
Thanks for preparing this. |
Yep, I did that : it's the only |
Could you prepare a fix for this one use? |
You mean, changing the code of |
Documentation preview for this PR (built with commit 4122508; changes) is ready! 🎉 |
OK, updating all of these color/rgbcolor renames is of course a better solution. That would belong on a separate PR |
just use ``deprecation_cython()`` instead. The usage of ``deprecation_cython()`` | ||
is exactly the same as ``deprecation()``. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just use ``deprecation_cython()`` instead. The usage of ``deprecation_cython()`` | |
is exactly the same as ``deprecation()``. | |
just use :func:`~sage.misc.superseded.deprecation_cython` instead. The usage of :func:`~sage.misc.superseded.deprecation_cython` | |
is exactly the same as :func:`~sage.misc.superseded.deprecation`. |
Deprecation | ||
|
||
=========== |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deprecation | |
=========== | |
Deprecation | |
=========== |
…ons : - documented deprecation_cython function used to deprecate in cython files (the function was totally absent from documentation) - added a paragraph to note that decorators don't work in cython and that (deprecation_cython should be used instead).
I just made the suggested changes by @mkoeppe, but there's a doctest that fails :
Any idea why ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,. thanks.
…egarding deprecation In PR sagemath#37721, I attempted to deprecate the ``ring`` keyword argument in the ``matrix`` constructor using ``@rename_keyword`` documented [here](https://doc.sagemath.org/htm l/en/developer/coding_in_python.html#deprecation). It did not work. The code compiled exactly as if the decorator wasn't there. I asked @mkoeppe why, he answered it "would be worth investigating and documenting". After some investigation, I came to the conclusion that developers cannot use ``@rename_keyword`` and other such decorators in Cython files. My solution was to use ``deprecation_cython`` (this was accepted and merged). Since many other developers might end up having the exact same problem, I simply suggest redirecting them to ``deprecation_cython``, by adding what's necessary in the docs. In this regard, I added a paragraph mentioning this in the Developer's guide, as all of this was **totally absent** from documentation. This way other developers won't need to investigate and spend time debugging non-working code. :) <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#37807 Reported by: SandwichGouda Reviewer(s): Matthias Köppe
… in farey_symbol.pyx See sagemath#37807 for discussion. The keyword was renamed and is deprecated since 2013 : it is high-time we get rid of the old version. Besides, ``@rename_keyword`` does not work properly in Cython files (see sagemath#37807 ) <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#37808 Reported by: SandwichGouda Reviewer(s):
… in farey_symbol.pyx See sagemath#37807 for discussion. The keyword was renamed and is deprecated since 2013 : it is high-time we get rid of the old version. Besides, ``@rename_keyword`` does not work properly in Cython files (see sagemath#37807 ) <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#37808 Reported by: SandwichGouda Reviewer(s):
In PR #37721, I attempted to deprecate the
ring
keyword argument in thematrix
constructorusing
@rename_keyword
documented here.It did not work. The code compiled exactly as if the decorator wasn't there.
I asked @mkoeppe why, he answered it "would be worth investigating and documenting".
After some investigation, I came to the conclusion that developers cannot use
@rename_keyword
andother such decorators in Cython files.
My solution was to use
deprecation_cython
(this was accepted and merged).Since many other developers might end up having the exact same problem, I simply suggest redirecting them
to
deprecation_cython
, by adding what's necessary in the docs.In this regard, I added a paragraph mentioning this in the Developer's guide, as all of this was totally absent from documentation.
This way other developers won't need to investigate and spend time debugging non-working code. :)
📝 Checklist
⌛ Dependencies