-
-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement the ladder idempotents of the symmetric group algebra #37859
Conversation
@AndrewMathas This is something I came across while trying to devise a method to construct the projective covers. Thought it might be worthwhile to add. |
The Apart from these minor points, everything seems fine. I have forgotten the protocols when reviewing. In particular, I don't remember when it is permissible for me to make these changes or if I suggest you make them. When I went to test your code I discovered that I have the following method that returns a dictionary of the e-ladders of a partition. def ladders(self,e):
"""INPUT: ladders(``e``), for a non-negative integer ``e``.
Returns a dictionary containing the ladders in the diagram of the partition.
A node $(i,j)$ in a partition belongs to the $l$th $e$-ladder where
$l=(e-1)r+c$.
EXAMPLES::
sage: Partition([3,2]).ladders(3)
{0: [(0, 0)], 1: [(0, 1)], 2: [(0, 2), (1, 0)], 3: [(1, 1)]}
"""
lads={}
for row in range(len(self)):
for col in range(self[row]):
l=col+row*(e-1)
if not l in lads: lads[l]=[]
lads[l].append((row,col))
return lads I suggest that this method be added as part of this PR. |
8255cb9
to
164a678
Compare
Thank you. That's a good point. I think I lost track of what In the trac workflow, you would be allowed to push commits. However, with GH this has become very inconvenient for reviewers (or general collaborative code writing) to do... (The "standard" ways would be to either do a PR to the branch on my fork (not the main repo here); just do your own PR with the additional commit(s); or I pull commits from a specific branch of yours) Well, no matter what I am okay with you pushing changes in one form or another (we might even set up something so you can just generically push to my fork, but it might not be worth the trouble) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but one more minor change that I should have picked up the first time.
src/sage/combinat/partition.py
Outdated
of the partition `\lambda` from left-to-right. | ||
The `e`-*ladder tableau* is the standard Young tableau obtained | ||
by reading the *ladders*, the set of cells `(i, j)` that differ | ||
from `(i+e-1, j-1)`, of the partition `\lambda` from left-to-right. | ||
|
||
INPUT: | ||
|
||
- ``e`` -- a positive integer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, should have caught this earlier too. You want e
to be a non-negative integer, where e=0
corresponds to (quantum) characteristic 0.
src/sage/combinat/partition.py
Outdated
[1, 1, 2, 2, 3, 3, 3] | ||
""" | ||
Tlad = [[None] * val for val in self] | ||
counter = 0 | ||
start = 0 | ||
n = sum(self) | ||
sizes = [] | ||
e -= 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To cope with e=0
this could be: e = self.size() if e=0 else e-1
What do you want |
Since Edit: actually, |
For the
In particular, see the ladder for the cell |
Good catch: I evidently had not applied my comment to the
This is correct because the "ladder index" depends on Btw, Steen's ladder idempotents still make sense when |
If you're happy, then I will set this to a positive review. |
Thank you. I added some more documentation and examples to illustrate these points about |
Thanks for your changes. |
Thank you. Could you also please approve the PR by going to the "files changed" and do the "review changes" with selecting the "approve"? |
4c94243
to
c84f55d
Compare
(The last force push was just to remove some trailing whitespace I accidentally added.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good to me.
Thank you. |
Docs don't build (see CI) |
Sorry about that; fixed. |
Documentation preview for this PR (built with commit 5754976; changes) is ready! 🎉 |
…roup algebra <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> We implement the so-called ladder idempotents of the symmetric group algebra $F[S_n]$, defined by Ryom-Hansen, which can be used to construct the projective covers of simple modules when the field $F$ has positive characteristic. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#37859 Reported by: Travis Scrimshaw Reviewer(s): Andrew Mathas
…roup algebra <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> We implement the so-called ladder idempotents of the symmetric group algebra $F[S_n]$, defined by Ryom-Hansen, which can be used to construct the projective covers of simple modules when the field $F$ has positive characteristic. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#37859 Reported by: Travis Scrimshaw Reviewer(s): Andrew Mathas
…roup algebra <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> We implement the so-called ladder idempotents of the symmetric group algebra $F[S_n]$, defined by Ryom-Hansen, which can be used to construct the projective covers of simple modules when the field $F$ has positive characteristic. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#37859 Reported by: Travis Scrimshaw Reviewer(s): Andrew Mathas
We implement the so-called ladder idempotents of the symmetric group algebra$F[S_n]$ , defined by Ryom-Hansen, which can be used to construct the projective covers of simple modules when the field $F$ has positive characteristic.
📝 Checklist
⌛ Dependencies