Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate is_AbelianGroup, is_DualAbelianGroup, is_MatrixGroup #37898

Merged
merged 3 commits into from
May 12, 2024
Merged

Deprecate is_AbelianGroup, is_DualAbelianGroup, is_MatrixGroup #37898

merged 3 commits into from
May 12, 2024

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Apr 29, 2024 •
edited
Loading

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@mkoeppe mkoeppe changed the title Deprecate is_AbelianGroup Deprecate is_AbelianGroup, is_DualAbelianGroup, is_MatrixGroup Apr 29, 2024
@mkoeppe mkoeppe self-assigned this Apr 29, 2024
@mkoeppe mkoeppe marked this pull request as ready for review April 29, 2024 06:05
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 29, 2024 •
edited
Loading

Documentation preview for this PR (built with commit ec586f2; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

mantepse
mantepse reviewed Apr 29, 2024
View reviewed changes
src/sage/groups/abelian_gps/abelian_group.py
True
sage: is_AbelianGroup(AbelianGroup(7, [3]*7))
True
"""
from sage.misc.superseded import deprecation
deprecation(37898, "the function is_AbelianGroup is deprecated; use 'isinstance(..., AbelianGroup_class)' instead")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't that be use 'in Groups.Commutative', @fchapoton?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just checked, yes, that's the pattern. For example:

deprecation(35999, "the function is_CommutativeAlgebra is deprecated; use '... in Algebras(base_ring).Commutative()' instead")

or

deprecation(35253, "the function is_Algebra is deprecated; use '... in Algebras(base_ring)' instead")

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did use this pattern in these other deprecation messages when there was at least some indication that these is_... functions were used with this meaning.
But is_AbelianGroup has never been used with a meaning other than this specific isinstance test.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 8, 2024

Thanks!

vbraun pushed a commit to vbraun/sage that referenced this pull request May 9, 2024
sagemathgh-37898: Deprecate is_AbelianGroup, is_DualAbelianGroup,…
57b5511 
… `is_MatrixGroup`

    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->



### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#37898
Reported by: Matthias Köppe
Reviewer(s): Martin Rubey, Matthias Köppe, Vincent Delecroix
vbraun pushed a commit to vbraun/sage that referenced this pull request May 11, 2024
sagemathgh-37898: Deprecate is_AbelianGroup, is_DualAbelianGroup,…
3d3edbd 
… `is_MatrixGroup`

    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->



### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#37898
Reported by: Matthias Köppe
Reviewer(s): Martin Rubey, Matthias Köppe, Vincent Delecroix
vbraun pushed a commit to vbraun/sage that referenced this pull request May 12, 2024
sagemathgh-37898: Deprecate is_AbelianGroup, is_DualAbelianGroup,…
a128ae0 
… `is_MatrixGroup`

    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->



### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#37898
Reported by: Matthias Köppe
Reviewer(s): Martin Rubey, Matthias Köppe, Vincent Delecroix
@vbraun vbraun merged commit 2627932 into sagemath:develop May 12, 2024
15 checks passed
@mkoeppe mkoeppe added this to the sage-10.4 milestone May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mantepse mantepse mantepse left review comments

@videlec videlec videlec approved these changes

Assignees

@mkoeppe mkoeppe

Labels
c: group theory t: refactoring v: minimal
Projects
None yet
Milestone
sage-10.4
Development

Successfully merging this pull request may close these issues.
4 participants
@mkoeppe @videlec @mantepse @vbraun