Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate is_Category, is_Endset, is_Homset, is_Parent, is_RingHomset, is_SimplicialComplexHomset #37922

Merged
merged 6 commits into from
May 25, 2024
Merged

Deprecate is_Category, is_Endset, is_Homset, is_Parent, is_RingHomset, is_SimplicialComplexHomset #37922

merged 6 commits into from
May 25, 2024

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented May 2, 2024 •
edited
Loading

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@mkoeppe mkoeppe self-assigned this May 2, 2024
@mkoeppe mkoeppe changed the title Deprecate is_Category Deprecate is_Category, is_Endset, is_Homset, is_Parent, is_RingHomset, is_SimplicialComplexHomset` May 2, 2024
@mkoeppe mkoeppe changed the title Deprecate is_Category, is_Endset, is_Homset, is_Parent, is_RingHomset, is_SimplicialComplexHomset` Deprecate is_Category, is_Endset, is_Homset, is_Parent, is_RingHomset, is_SimplicialComplexHomset May 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024 •
edited
Loading

Documentation preview for this PR (built with commit 78bfdcb; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@mkoeppe mkoeppe marked this pull request as ready for review May 2, 2024 16:57
@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 8, 2024

Thank you!

vbraun pushed a commit to vbraun/sage that referenced this pull request May 9, 2024
sagemathgh-37922: Deprecate is_Category, is_Endset, is_Homset, …
ff465b3 
…`is_Parent`, `is_RingHomset`, `is_SimplicialComplexHomset`

    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->



### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#37922
Reported by: Matthias Köppe
Reviewer(s): Vincent Delecroix
@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 12, 2024

trivial rebase

vbraun pushed a commit to vbraun/sage that referenced this pull request May 15, 2024
sagemathgh-37922: Deprecate is_Category, is_Endset, is_Homset, …
d7f6a14 
…`is_Parent`, `is_RingHomset`, `is_SimplicialComplexHomset`

    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->



### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#37922
Reported by: Matthias Köppe
Reviewer(s): Vincent Delecroix
vbraun pushed a commit to vbraun/sage that referenced this pull request May 18, 2024
sagemathgh-37922: Deprecate is_Category, is_Endset, is_Homset, …
5338298 
…`is_Parent`, `is_RingHomset`, `is_SimplicialComplexHomset`

    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->



### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#37922
Reported by: Matthias Köppe
Reviewer(s): Vincent Delecroix
vbraun pushed a commit to vbraun/sage that referenced this pull request May 18, 2024
sagemathgh-37922: Deprecate is_Category, is_Endset, is_Homset, …
a22721f 
…`is_Parent`, `is_RingHomset`, `is_SimplicialComplexHomset`

    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->



### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#37922
Reported by: Matthias Köppe
Reviewer(s): Vincent Delecroix
@vbraun vbraun merged commit 25a5f96 into sagemath:develop May 25, 2024
5 of 11 checks passed
@mkoeppe mkoeppe added this to the sage-10.4 milestone May 25, 2024
@mkoeppe mkoeppe deleted the is_Category_deprecation branch May 25, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@videlec videlec videlec approved these changes

Assignees

@mkoeppe mkoeppe

Labels
c: categories t: refactoring v: small
Projects
None yet
Milestone
sage-10.4
Development

Successfully merging this pull request may close these issues.
3 participants
@mkoeppe @videlec @vbraun