Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate is_FGP_Module, is_FilteredVectorSpace, is_FreeQuadraticModule, is_FreeModule, is_FreeModuleHomspace, is_MatrixSpace, is_Module, is_VectorSpace, is_VectorSpaceHomspace #37924

Merged
merged 11 commits into from
May 25, 2024
Merged

Deprecate is_FGP_Module, is_FilteredVectorSpace, is_FreeQuadraticModule, is_FreeModule, is_FreeModuleHomspace, is_MatrixSpace, is_Module, is_VectorSpace, is_VectorSpaceHomspace #37924

merged 11 commits into from
May 25, 2024

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented May 2, 2024 •
edited
Loading

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@mkoeppe mkoeppe self-assigned this May 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024 •
edited
Loading

Documentation preview for this PR (built with commit 72e46f7; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@mkoeppe mkoeppe changed the title Deprecate is_Module, is_VectorSpace Deprecate is_FreeQuadraticModule, is_FreeModule, is_Module, is_VectorSpace May 2, 2024
@mkoeppe mkoeppe changed the title Deprecate is_FreeQuadraticModule, is_FreeModule, is_Module, is_VectorSpace Deprecate is_FGP_Module, is_FilteredVectorSpace, is_FreeQuadraticModule, is_FreeModule, is_FreeModuleHomspace, is_MatrixSpace, is_Module, is_VectorSpace, is_VectorSpaceHomspace May 3, 2024
@mkoeppe mkoeppe marked this pull request as ready for review May 12, 2024 00:37
Matthias Koeppe added 11 commits May 12, 2024 16:55
@mkoeppe
src/sage/modules/module.pyx: Deprecate is_Module, is_VectorSpace
c861f3c
@mkoeppe
src/sage/modules/free_quadratic_module.py: Deprecate is_FreeQuadratic…
1efa331 
…Module
@mkoeppe
src/sage/modules/free_module.py: Deprecate is_FreeModule
1219748
@mkoeppe
src/sage/modules/fg_pid/fgp_module.py: Deprecate is_FGP_Module
a15c49f
@mkoeppe
src/sage/modules/free_module_homspace.py: Deprecate is_FreeModuleHoms…
a91e7b8 
…pace
@mkoeppe
src/sage/modules/vector_space_homspace.py: Deprecate is_VectorSpaceHo…
791c58a 
…mspace
@mkoeppe
src/sage/matrix/matrix_space.py: Deprecate is_MatrixSpace
8682043
@mkoeppe
src/sage/modules/filtered_vector_space.py: Deprecate is_FilteredVecto…
4796d79 
…rSpace
@mkoeppe
Update doctests for deprecation warnings
d6f29ba
@mkoeppe
src/sage/modules/module.pyx: Update doctest with deprecation
729878b
@mkoeppe
src/sage/modules/vector_space_morphism.py: Remove use of is_VectorSpace
72e46f7
@orlitzky
Copy link
Contributor

It might be helpful to say "check that the base ring is a field" for is_VectorSpace, but LGTM anyway. The code for is_VectorSpace is still there to be inspected.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 14, 2024

Thank you!

vbraun pushed a commit to vbraun/sage that referenced this pull request May 15, 2024
sagemathgh-37924: Deprecate is_FGP_Module, is_FilteredVectorSpace…
7935745 
…, `is_FreeQuadraticModule`, `is_FreeModule`, `is_FreeModuleHomspace`, `is_MatrixSpace`, `is_Module`, `is_VectorSpace`, `is_VectorSpaceHomspace`

    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->



### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#37924
Reported by: Matthias Köppe
Reviewer(s):
vbraun pushed a commit to vbraun/sage that referenced this pull request May 18, 2024
sagemathgh-37924: Deprecate is_FGP_Module, is_FilteredVectorSpace…
f1877c6 
…, `is_FreeQuadraticModule`, `is_FreeModule`, `is_FreeModuleHomspace`, `is_MatrixSpace`, `is_Module`, `is_VectorSpace`, `is_VectorSpaceHomspace`

    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->



### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#37924
Reported by: Matthias Köppe
Reviewer(s):
vbraun pushed a commit to vbraun/sage that referenced this pull request May 18, 2024
sagemathgh-37924: Deprecate is_FGP_Module, is_FilteredVectorSpace…
2df6346 
…, `is_FreeQuadraticModule`, `is_FreeModule`, `is_FreeModuleHomspace`, `is_MatrixSpace`, `is_Module`, `is_VectorSpace`, `is_VectorSpaceHomspace`

    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->



### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#37924
Reported by: Matthias Köppe
Reviewer(s):
@vbraun vbraun merged commit 11aff1e into sagemath:develop May 25, 2024
12 of 14 checks passed
@mkoeppe mkoeppe added this to the sage-10.4 milestone May 25, 2024
@mkoeppe mkoeppe deleted the is_Module_deprecation branch May 25, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mkoeppe mkoeppe

Labels
c: linear algebra t: refactoring v: moderate
Projects
None yet
Milestone
sage-10.4
Development

Successfully merging this pull request may close these issues.
3 participants
@mkoeppe @orlitzky @vbraun