Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DualMatroid: Add is_valid and relabel methods #38013

Merged
merged 2 commits into from
May 25, 2024

Conversation

gmou3
Copy link
Contributor

@gmou3 gmou3 commented May 16, 2024

Implement class-specific is_valid and relabel methods.
Previously, such functionality was achieved through the generic and very slow rank-based algorithms.

The PR also does a touch-up of the docstrings of dual_matroid.py.

Copy link

github-actions bot commented May 16, 2024

Documentation preview for this PR (built with commit 54777b5; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@gmou3 gmou3 requested a review from tscrim May 16, 2024 21:26
Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo one little thing.

src/sage/matroids/dual_matroid.py Outdated Show resolved Hide resolved
@tscrim
Copy link
Collaborator

tscrim commented May 17, 2024

LGTM. Thanks.

vbraun pushed a commit to vbraun/sage that referenced this pull request May 18, 2024
    
Implement class-specific `is_valid` and `relabel` methods.
Previously, such functionality was achieved through the generic and very
slow rank-based algorithms.

The PR also does a touch-up of the docstrings of `dual_matroid.py`.
    
URL: sagemath#38013
Reported by: gmou3
Reviewer(s): gmou3, Travis Scrimshaw
@vbraun vbraun merged commit 0dc8b4e into sagemath:develop May 25, 2024
17 checks passed
@gmou3 gmou3 deleted the dual_relabel_and_is_valid branch May 25, 2024 15:26
@mkoeppe mkoeppe added this to the sage-10.4 milestone May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants