Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sage.modular: Deprecate is_... functions #38035

Merged
merged 7 commits into from
Jun 1, 2024
Merged

sage.modular: Deprecate is_... functions #38035

merged 7 commits into from
Jun 1, 2024

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented May 20, 2024

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@mkoeppe mkoeppe self-assigned this May 20, 2024
@mkoeppe mkoeppe force-pushed the is_ModularAbelianVariety_deprecation branch from 01d1c6d to 7f45086 Compare May 20, 2024 07:42
@mkoeppe mkoeppe marked this pull request as ready for review May 20, 2024 07:48
@github-actions GitHub Actions
Copy link

github-actions bot commented May 20, 2024 •
edited
Loading

Documentation preview for this PR (built with commit a948b57; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

kwankyu
kwankyu approved these changes May 24, 2024
View reviewed changes
Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 25, 2024

Thank you!

Matthias Koeppe added 6 commits May 25, 2024 10:50
@mkoeppe
for a in "CLASS='ModularAbelianVariety';SUFFIX=_abstract" "CLASS='Ari…
452797a 
…thmeticSubgroup|ModularFormsSpace|ModularSymbolsSpace';SUFFIX=" "CLASS='Gamma|Gamma0|Gamma1|GammaH|SL2Z|DirichletGroup';SUFFIX='_class'" "CLASS='CongruenceSubgroup';SUFFIX='Base'"; do eval "$a"; git --no-pager grep -l -E 'is_('$CLASS')' | xargs sed -E -i.bak 's/import is_('$CLASS')/import \1'$SUFFIX'/;/^ +/s/is_('$CLASS')[(]([^()]*([(][^()]*[)])?[^()]*)[)]/isinstance(\2, \1'$SUFFIX')/g'; done
@mkoeppe
fixup isinstance
3e45e18
@mkoeppe
reverts
331377b
@mkoeppe
fixups
8eada3f
@mkoeppe
deprecations
ffa9f3b
@mkoeppe
git --no-pager grep -l 'deprecation(' src/sage/modular | xargs sed -i…
b65ea36 
….bak '/ is deprecated; use /s/the function /The function /;/ is deprecated; use /s/ instead/ instead./'
@mkoeppe mkoeppe force-pushed the is_ModularAbelianVariety_deprecation branch from f38963b to b65ea36 Compare May 25, 2024 17:52
@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 25, 2024

rebased

@vbraun
Copy link
Member

vbraun commented May 25, 2024

Please don't set non-working PRs to positive review

@mkoeppe mkoeppe force-pushed the is_ModularAbelianVariety_deprecation branch from 91727c4 to a948b57 Compare May 25, 2024 23:46
@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 25, 2024

Sorry, fixed now

vbraun pushed a commit to vbraun/sage that referenced this pull request May 27, 2024
sagemathgh-38035: sage.modular: Deprecate is_... functions
605c6dd 
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->



### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#38035
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee, Matthias Köppe
vbraun pushed a commit to vbraun/sage that referenced this pull request May 29, 2024
sagemathgh-38035: sage.modular: Deprecate is_... functions
668d7b2 
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->



### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#38035
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee, Matthias Köppe
@vbraun vbraun merged commit a965249 into sagemath:develop Jun 1, 2024
15 checks passed
@mkoeppe mkoeppe added this to the sage-10.4 milestone Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwankyu kwankyu kwankyu approved these changes

Assignees

@mkoeppe mkoeppe

Labels
c: modular forms t: refactoring v: large
Projects
None yet
Milestone
sage-10.4
Development

Successfully merging this pull request may close these issues.
3 participants
@mkoeppe @vbraun @kwankyu