CI Build&Test: Split test-long into multiple jobs, repair Coverage.py upload #38090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit a0262b6; changes) is ready! 🎉 |
mkoeppe
force-pushed
the
ci_split_long_tests
branch
5 times, most recently
from
53727f8
to
d24f52f
Compare
mkoeppe
force-pushed
the
ci_split_long_tests
branch
4 times, most recently
from
c1177cc
to
2d31669
Compare
mkoeppe
force-pushed
the
ci_split_long_tests
branch
from
2d31669
to
46f5148
Compare
mkoeppe
changed the title
|
Is there an example run? This is to save 15 minutes. Is it worth the effort? Workflow scripts are the second-class citizen. But in the long run, they are still burden of the community. The workflow script gets more complicated. Saving 15 minutes is worth it? |
Yes, right here on the PR |
... to completion of all jobs, yes. But the time to completion of test-long is cut in half from 100 minutes to 50 minutes |
|
From the example run, Could we remove the warnings? |
OK. Certainly nice reward for the effort. |
Trying in a0262b6 |
|
Thank you! |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 29, 2024
…repair Coverage.py upload
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->
test-long (90 minutes) runs after a successful test-new (10 minutes).
This is the critical path (100 minutes), longer than build-docs-pdf (85
minutes). We split it into multiple parallel jobs (33 minutes), merging
the coverage files in a job afterwards (6 minutes).
This also repairs the Coverage.py upload, which apparently got broken.
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
URL: sagemath#38090
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test-long (90 minutes) runs after a successful test-new (10 minutes). This is the critical path (100 minutes), longer than build-docs-pdf (85 minutes). We split it into multiple parallel jobs (33 minutes), merging the coverage files in a job afterwards (6 minutes).
This also repairs the Coverage.py upload, which apparently got broken.
📝 Checklist
⌛ Dependencies