Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various Python package upgrades #38101

Merged
merged 28 commits into from
Jun 22, 2024
Merged

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented May 27, 2024

and incidental updates to the sage --package script

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

Copy link

github-actions bot commented May 27, 2024

Documentation preview for this PR (built with commit 21e2a49; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 11, 2024

Thanks!

vbraun pushed a commit to vbraun/sage that referenced this pull request Jun 16, 2024
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

and incidental updates to the `sage --package` script

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#38101
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee
vbraun pushed a commit to vbraun/sage that referenced this pull request Jun 16, 2024
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

and incidental updates to the `sage --package` script

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#38101
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee
@vbraun
Copy link
Member

vbraun commented Jun 16, 2024

Error message for exceptiongroup changed

`**********************************************************************
File "src/sage/databases/symbolic_data.py", line 184, in sage.databases.symbolic_data.SymbolicData.__getattr__
Failed example:
    sd.Cyclic5 # optional - database_symbolic_data
Expected:
    Traceback (most recent call last):
    ...
    AttributeError: No ideal matching 'Cyclic5' found in database.
Got:
    <BLANKLINE>
    Traceback (most recent call last):
      File "/var/lib/buildbot/slave/sage_git/build/src/sage/databases/symbolic_data.py", line 150, in get_ideal
        open(name)
    FileNotFoundError: [Errno 2] No such file or directory: '/var/lib/buildbot/slave/sage_git/build/local/share/symbolic_data/Data/XMLResources/INTPS/Cyclic5.xml'
    <BLANKLINE>
    During handling of the above exception, another exception occurred:
    <BLANKLINE>
    Traceback (most recent call last):
      File "/var/lib/buildbot/slave/sage_git/build/src/sage/databases/symbolic_data.py", line 154, in get_ideal
        open(name)
    FileNotFoundError: [Errno 2] No such file or directory: '/var/lib/buildbot/slave/sage_git/build/local/share/symbolic_data/Data/XMLResources/GenPS//var/lib/buildbot/slave/sage_git/build/local/share/symbolic_data/Data/XMLResources/INTPS/Cyclic5.xml.xml'
    <BLANKLINE>
    During handling of the above exception, another exception occurred:
    <BLANKLINE>
    Traceback (most recent call last):
      File "/var/lib/buildbot/slave/sage_git/build/src/sage/doctest/forker.py", line 715, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/var/lib/buildbot/slave/sage_git/build/src/sage/doctest/forker.py", line 1147, in compile_and_execute
        exec(compiled, globs)
      File "<doctest sage.databases.symbolic_data.SymbolicData.__getattr__[1]>", line 1, in <module>
        sd.Cyclic5 # optional - database_symbolic_data
        ^^^^^^^^^^
      File "/var/lib/buildbot/slave/sage_git/build/src/sage/databases/symbolic_data.py", line 196, in __getattr__
        return self.get_ideal(name)
               ^^^^^^^^^^^^^^^^^^^^
      File "/var/lib/buildbot/slave/sage_git/build/src/sage/databases/symbolic_data.py", line 156, in get_ideal
        raise AttributeError("No ideal matching '%s' found in database." % orig_name)
    AttributeError: No ideal matching 'Cyclic5' found in database.. Did you mean: 'Cyclic_5'?
**********************************************************************
1 item had failures:
   1 of   4 in sage.databases.symbolic_data.SymbolicData.__getattr__
    [13 tests, 1 failure, 0.08 s]
----------------------------------------------------------------------
sage -t --long --random-seed=0 src/sage/databases/symbolic_data.py  # 1 doctest failed
----------------------------------------------------------------------

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 16, 2024

What's this got to do with exceptiongroup? Sure you tested this optional package before?

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 16, 2024

Anyway, here's a fix

@vbraun
Copy link
Member

vbraun commented Jun 16, 2024

Yes, that optional package is on one of the buildbots

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 16, 2024

Then what's new is probably that you're testing it with python 3.12

vbraun pushed a commit to vbraun/sage that referenced this pull request Jun 19, 2024
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

and incidental updates to the `sage --package` script

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->

URL: sagemath#38101
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee
@vbraun vbraun merged commit b7e60e1 into sagemath:develop Jun 22, 2024
25 of 38 checks passed
@mkoeppe mkoeppe deleted the package_upgrades_10.4 branch June 22, 2024 20:29
@mkoeppe mkoeppe added this to the sage-10.4 milestone Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants