Fixed bug in size labeler #38114
Merged
Fixed bug in size labeler #38114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit aaface6; changes) is ready! 🎉 |
mkoeppe
reviewed
May 30, 2024
amanmoon
force-pushed
the
bug/size_labeler
branch
from
2906bf9
to
aaface6
Compare
|
Thank you! LGTM. |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 3, 2024
Moved the file set_labels_by_changes.sh to to the .ci directory. The workflow runs from the main repo. Fixed bug, the correct labels will be added even if the feature branch is behind. sagemath#37262 sagemath#37262 (comment) https://groups.google.com/g/sage-devel/c/w4IeYgXgVUc/m/Og7NP-3VAQAJ <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. URL: sagemath#38114 Reported by: Aman Moon Reviewer(s): Matthias Köppe
Thanks for taking this while I was on vacation! |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 4, 2024
Moved the file set_labels_by_changes.sh to to the .ci directory. The workflow runs from the main repo. Fixed bug, the correct labels will be added even if the feature branch is behind. sagemath#37262 sagemath#37262 (comment) https://groups.google.com/g/sage-devel/c/w4IeYgXgVUc/m/Og7NP-3VAQAJ <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. URL: sagemath#38114 Reported by: Aman Moon Reviewer(s): Matthias Köppe
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 5, 2024
Moved the file set_labels_by_changes.sh to to the .ci directory. The workflow runs from the main repo. Fixed bug, the correct labels will be added even if the feature branch is behind. sagemath#37262 sagemath#37262 (comment) https://groups.google.com/g/sage-devel/c/w4IeYgXgVUc/m/Og7NP-3VAQAJ <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. URL: sagemath#38114 Reported by: Aman Moon Reviewer(s): Matthias Köppe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the file set_labels_by_changes.sh to to the .ci directory.
The workflow runs from the main repo.
Fixed bug, the correct labels will be added even if the feature branch is behind.
#37262
#37262 (comment)
https://groups.google.com/g/sage-devel/c/w4IeYgXgVUc/m/Og7NP-3VAQAJ