Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate is_Fan, is_NefPartition, is_PointCollection, is_ToricLattice, is_ToricLatticeElement, is_ToricLatticeQuotient #38126

Merged
merged 4 commits into from
Jun 9, 2024
Merged

Deprecate is_Fan, is_NefPartition, is_PointCollection, is_ToricLattice, is_ToricLatticeElement, is_ToricLatticeQuotient #38126

merged 4 commits into from
Jun 9, 2024

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Jun 1, 2024 •
edited
Loading

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

Matthias Koeppe added 2 commits May 31, 2024 21:45
@mkoeppe
for a in "CLASS='ToricLatticeElement|PointCollection|NefPartition';SU…
f26975f 
…FFIX=" "CLASS='ToricLattice';SUFFIX=_generic"; do eval "$a"; git --no-pager grep -l -E 'is_('$CLASS')' src/sage | xargs sed -E -i.bak 's/import is_('$CLASS')/import \1'$SUFFIX'/;/^ +/s/is_('$CLASS')[(]([^()]*([(][^()]*[)])?[^()]*)[)]/isinstance(\2, \1'$SUFFIX')/g'; done
@mkoeppe
Deprecate is_Fan
39313d0
@mkoeppe mkoeppe self-assigned this Jun 1, 2024
@mkoeppe mkoeppe marked this pull request as draft June 1, 2024 05:05
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 1, 2024 •
edited
Loading

Documentation preview for this PR (built with commit 18e9f71; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@mkoeppe mkoeppe changed the title Deprecate is_Fan Deprecate is_Fan, is_NefPartition, is_PointCollection, is_ToricLattice, is_ToricLatticeElement, is_ToricLatticeQuotient Jun 1, 2024
@mkoeppe mkoeppe marked this pull request as ready for review June 1, 2024 06:01
kwankyu
kwankyu approved these changes Jun 1, 2024
View reviewed changes
Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 3, 2024

Thanks again.

vbraun pushed a commit to vbraun/sage that referenced this pull request Jun 4, 2024
sagemathgh-38126: Deprecate is_Fan, is_NefPartition, `is_PointCol…
2b4394b 
…lection`, `is_ToricLattice`, `is_ToricLatticeElement`, `is_ToricLatticeQuotient`

    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->



### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#38126
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee
vbraun pushed a commit to vbraun/sage that referenced this pull request Jun 5, 2024
sagemathgh-38126: Deprecate is_Fan, is_NefPartition, `is_PointCol…
4b104d2 
…lection`, `is_ToricLattice`, `is_ToricLatticeElement`, `is_ToricLatticeQuotient`

    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->



### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#38126
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee
@vbraun vbraun merged commit 7f4fb99 into sagemath:develop Jun 9, 2024
22 checks passed
@mkoeppe mkoeppe added this to the sage-10.4 milestone Jun 9, 2024
@mkoeppe mkoeppe deleted the is_Fan_deprecation branch June 9, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwankyu kwankyu kwankyu approved these changes

Assignees

@mkoeppe mkoeppe

Labels
c: geometry t: refactoring v: moderate
Projects
None yet
Milestone
sage-10.4
Development

Successfully merging this pull request may close these issues.
3 participants
@mkoeppe @kwankyu @vbraun