-
-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix live doc build by saving runner space #38129
Conversation
Documentation preview for this PR (built with commit 2d56d27; changes) is ready! 🎉 |
Is there a test run already somewhere? |
I ran it here: https://github.com/kwankyu/sage/actions/runs/9424396249 (second try). Let's see. |
It works well. |
Then let's merge it. |
Thanks! |
I am confused by this: https://github.com/sagemath/sage/actions/runs/9357979101 That run succeeded in building live doc. Then this PR is not really needed...? |
In particular, this step
worked as it is in the run. I thought this step would not work correctly because the commands run inside the docker container and hence create the file |
The container mounts the current directory ( |
I see. That explains it. How about the space problem? Should we see the success of the last run as a sheer luck? |
It's better to save the space. It's clear that we are operating very close to the edge with our builds on these runners |
I reviewed the last runs for from beta5 to beta8. Only the run for beta8 failed by lack of space.
OK. Thanks. |
<!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> as seen in: https://github.com/sagemath/sage/actions/runs/9333677258/job/25690941738 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#38129 Reported by: Kwankyu Lee Reviewer(s): Kwankyu Lee, Matthias Köppe
<!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> as seen in: https://github.com/sagemath/sage/actions/runs/9333677258/job/25690941738 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#38129 Reported by: Kwankyu Lee Reviewer(s): Kwankyu Lee, Matthias Köppe
<!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> as seen in: https://github.com/sagemath/sage/actions/runs/9333677258/job/25690941738 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#38129 Reported by: Kwankyu Lee Reviewer(s): Kwankyu Lee, Matthias Köppe
as seen in: https://github.com/sagemath/sage/actions/runs/9333677258/job/25690941738
📝 Checklist
⌛ Dependencies