Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix live doc build by saving runner space #38129

Merged
merged 4 commits into from
Jun 22, 2024

Conversation

kwankyu
Copy link
Collaborator

@kwankyu kwankyu commented Jun 2, 2024

as seen in: https://github.com/sagemath/sage/actions/runs/9333677258/job/25690941738

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@kwankyu kwankyu changed the title Save runner space for live doc building Fix live doc build by saving runner space Jun 2, 2024
@kwankyu kwankyu requested a review from mkoeppe June 2, 2024 04:46
Copy link

github-actions bot commented Jun 2, 2024

Documentation preview for this PR (built with commit 2d56d27; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@mkoeppe
Copy link
Contributor

mkoeppe commented Jun 7, 2024

Is there a test run already somewhere?

@kwankyu
Copy link
Collaborator Author

kwankyu commented Jun 7, 2024

I ran it here: https://github.com/kwankyu/sage/actions/runs/9424396249 (second try). Let's see.

@kwankyu
Copy link
Collaborator Author

kwankyu commented Jun 8, 2024

It works well.

@mkoeppe
Copy link
Contributor

mkoeppe commented Jun 8, 2024

Then let's merge it.

@mkoeppe mkoeppe added this to the sage-10.4 milestone Jun 8, 2024
@kwankyu
Copy link
Collaborator Author

kwankyu commented Jun 8, 2024

Thanks!

@kwankyu
Copy link
Collaborator Author

kwankyu commented Jun 9, 2024

I am confused by this: https://github.com/sagemath/sage/actions/runs/9357979101

That run succeeded in building live doc. Then this PR is not really needed...?

@kwankyu
Copy link
Collaborator Author

kwankyu commented Jun 9, 2024

In particular, this step

      - name: Copy live doc
        id: copylivedoc
        if: (success() || failure()) && steps.buildlivedoc.outcome == 'success'
        run: |
          mkdir -p ./livedoc
          cp -r -L /sage/local/share/doc/sage/html ./livedoc
          cp -r -L /sage/local/share/doc/sage/pdf ./livedoc
          cp  /sage/local/share/doc/sage/index.html ./livedoc
          zip -r livedoc.zip livedoc
        shell: sh .ci/docker-exec-script.sh BUILD . {0}

worked as it is in the run. I thought this step would not work correctly because the commands run inside the docker container and hence create the file livedoc.zip inside the container, and the upload step fails because the zip file is not accessible. I am misunderstanding something. What is it?

@mkoeppe
Copy link
Contributor

mkoeppe commented Jun 9, 2024

The container mounts the current directory (.) from the worker. These steps directly write to the worker file system.

@kwankyu
Copy link
Collaborator Author

kwankyu commented Jun 9, 2024

I see. That explains it.

How about the space problem? Should we see the success of the last run as a sheer luck?

@mkoeppe
Copy link
Contributor

mkoeppe commented Jun 9, 2024

It's better to save the space. It's clear that we are operating very close to the edge with our builds on these runners

@kwankyu
Copy link
Collaborator Author

kwankyu commented Jun 9, 2024

I reviewed the last runs for from beta5 to beta8. Only the run for beta8 failed by lack of space.

It's better to save the space. It's clear that we are operating very close to the edge with our builds on these runners

OK. Thanks.

vbraun pushed a commit to vbraun/sage that referenced this pull request Jun 10, 2024
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

as seen in:
https://github.com/sagemath/sage/actions/runs/9333677258/job/25690941738

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#38129
Reported by: Kwankyu Lee
Reviewer(s): Kwankyu Lee, Matthias Köppe
vbraun pushed a commit to vbraun/sage that referenced this pull request Jun 16, 2024
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

as seen in:
https://github.com/sagemath/sage/actions/runs/9333677258/job/25690941738

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#38129
Reported by: Kwankyu Lee
Reviewer(s): Kwankyu Lee, Matthias Köppe
vbraun pushed a commit to vbraun/sage that referenced this pull request Jun 16, 2024
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

as seen in:
https://github.com/sagemath/sage/actions/runs/9333677258/job/25690941738

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#38129
Reported by: Kwankyu Lee
Reviewer(s): Kwankyu Lee, Matthias Köppe
@vbraun vbraun merged commit ed39553 into sagemath:develop Jun 22, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants