Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build/pkgs/scip 9.0.1, soplex 7.0.1, papilo 2.2.1, onetbb 2021.12.0 #38147

Merged
merged 18 commits into from
Jun 9, 2024

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Jun 3, 2024

Minor update

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@mkoeppe mkoeppe self-assigned this Jun 3, 2024
@mkoeppe mkoeppe changed the title /build/pkgs/scip 9.0.1, soplex 7.0.1, papilo 2.2.1, onetbb 2021.12.0 build/pkgs/scip 9.0.1, soplex 7.0.1, papilo 2.2.1, onetbb 2021.12.0 Jun 3, 2024
Copy link

github-actions bot commented Jun 3, 2024

Documentation preview for this PR (built with commit c6970f8; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Matthias Koeppe added 2 commits June 3, 2024 13:43
Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 5, 2024

Thank you!

@mkoeppe mkoeppe added this to the sage-10.4 milestone Jun 6, 2024
vbraun pushed a commit to vbraun/sage that referenced this pull request Jun 8, 2024
…Uninstall/build changed packages; Linux Incremental: Update platforms

    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

Fixes handling of deletions/renames
- https://groups.google.com/g/sage-devel/c/tw6J8vU7IY0/m/IZxuGW8gBQAJ
- sagemath#36892 (comment)

When changes to packages are made, "CI Build&Test" now uses the same
logic as "CI Linux Incremental" for determining what SPKGs to uninstall
(so that spkg-configure.m4 is re-run) and what optional SPKGs to
install.

We update the platforms of "CI Linux Incremental" and remove the default
platform from there, to remove the duplication with "CI Build&Test".

- Also apparently fixes sagemath#37786

For a test run with a PR that actually makes changes to packages, see
- sagemath#38147

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#38144
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee, Matthias Köppe
@vbraun vbraun merged commit 229a364 into sagemath:develop Jun 9, 2024
28 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants