Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate is_FreeAlgebraQuotientElement, ... #38184

Merged
merged 7 commits into from
Jun 22, 2024
Merged

Deprecate is_FreeAlgebraQuotientElement, ... #38184

merged 7 commits into from
Jun 22, 2024

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Jun 10, 2024 •
edited
Loading

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

Matthias Koeppe added 2 commits June 10, 2024 00:17
@mkoeppe
for a in "CLASS='FreeAlgebraQuotientElement|Functor|AbelianGroupEleme…
7c32d0e 
…nt|DualAbelianGroupElement|PermutationGroupElement|ChainComplexHomspace|DirichletCharacter|ModularFormElement|ModularSymbolsElement|ManinSymbol|FreeModuleElement|FreeAbelianMonoidElement|FreeMonoidElement|LinearConstraint|LinearTensor|LinearTensorConstraint|Graphics|DiscreteProbabilitySpace|DiscreteRandomVariable';SUFFIX=" "CLASS='ProbabilitySpace|RandomVariable';SUFFIX=_generic"; do eval "$a"; git --no-pager grep -l -E 'is_('$CLASS')' src/sage | xargs sed -E -i.bak 's/import is_('$CLASS')/import \1'$SUFFIX'/;/^ +/s/is_('$CLASS')[(]([^()]*([(][^()]*[)])?[^()]*)[)]/isinstance(\2, \1'$SUFFIX')/g'; done
@mkoeppe
Fix up isinstance
19934c1
@mkoeppe mkoeppe self-assigned this Jun 10, 2024
@mkoeppe
for a in "CLASS='LinearFunction';SUFFIX=" ; do eval "$a"; git --no-pa…
6c7dabc 
…ger grep -l -E 'is_('$CLASS')' src/sage | xargs sed -E -i.bak 's/import is_('$CLASS')/import \1'$SUFFIX'/;/^ +/s/is_('$CLASS')[(]([^()]*([(][^()]*[)])?[^()]*)[)]/isinstance(\2, \1'$SUFFIX')/g'; done
@github-actions GitHub Actions
Copy link

Documentation preview for this PR (built with commit 6c7dabc; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@mkoeppe mkoeppe marked this pull request as ready for review June 10, 2024 23:47
kwankyu
kwankyu approved these changes Jun 11, 2024
View reviewed changes
Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 11, 2024

Thanks!

vbraun pushed a commit to vbraun/sage that referenced this pull request Jun 16, 2024
sagemathgh-38184: Deprecate is_FreeAlgebraQuotientElement, ...
e23ae9a 
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->



### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#38184
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee
vbraun pushed a commit to vbraun/sage that referenced this pull request Jun 16, 2024
sagemathgh-38184: Deprecate is_FreeAlgebraQuotientElement, ...
e14c991 
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->



### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#38184
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee
@vbraun vbraun merged commit 19724da into sagemath:develop Jun 22, 2024
19 of 21 checks passed
@mkoeppe mkoeppe deleted the is_FreeAlgebraQuotientElement_deprecation branch June 22, 2024 20:23
@mkoeppe mkoeppe added this to the sage-10.4 milestone Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwankyu kwankyu kwankyu approved these changes

Assignees

@mkoeppe mkoeppe

Labels
t: refactoring v: moderate
Projects
None yet
Milestone
sage-10.4
Development

Successfully merging this pull request may close these issues.
3 participants
@mkoeppe @kwankyu @vbraun