Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reject system gap 4.13 #38222

Merged
merged 2 commits into from
Jun 27, 2024
Merged

Reject system gap 4.13 #38222

merged 2 commits into from
Jun 27, 2024

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Jun 15, 2024 •
edited
Loading

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@mkoeppe mkoeppe added this to the sage-10.4 milestone Jun 15, 2024
@mkoeppe mkoeppe self-assigned this Jun 15, 2024
@github-actions GitHub Actions
Copy link

Documentation preview for this PR (built with commit 2faf15f; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@mkoeppe mkoeppe requested review from enriqueartal and vbraun June 16, 2024 23:40
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 22, 2024

Thanks, Volker.

vbraun pushed a commit to vbraun/sage that referenced this pull request Jun 22, 2024
sagemathgh-37998: Update conda-lock files, rename macOS conda-lock fi…
4a80002 
…les to match CI Conda, remove unexplained duplicate lock files

    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

The renaming is done so that the fix here can take effect on PR runs via
the "CI Fix" mechanism (as changes to the workflow files themselves
cannot take effect).
- Moreover, making arm64 the default platform for macOS makes sense
because all new macOS machines use this platform.

And update by running `.github/workflows/conda-lock-update.py` for all
architectures.

- Workflow matrix variables now contain `-latest`, to add tests for the
macOS x86_64 platform (runner name: `macos-13`)

- Removes some unexplained duplications (both `arm` and `arm64` files
for macOS, both `aarch` and `aarch64` for Linux)

- Fixes sagemath#37997

Author: @mkoeppe, @gmou3

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->

- Depends on sagemath#38033 (split out from here)
- Depends on sagemath#38034 (split out from here)
- Depends on sagemath#38222
    
URL: sagemath#37998
Reported by: Matthias Köppe
Reviewer(s):
vbraun pushed a commit to vbraun/sage that referenced this pull request Jun 22, 2024
sagemathgh-38222: Reject system gap 4.13
c5a3b55 
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->

URL: sagemath#38222
Reported by: Matthias Köppe
Reviewer(s):
@tornaria
Copy link
Contributor

-1

Nothing here explains why this should be a blocker, not even why this should happen at all.

@tornaria
Copy link
Contributor

#37884 (comment) shows that whatever issue you have is not about gap 4.13 but about a particular (broken?) install of gap.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 24, 2024

Nothing here explains why this should be a blocker, not even why this should happen at all.

Because we're trying to make a release, and your PR #37884 is not ready.

vbraun pushed a commit to vbraun/sage that referenced this pull request Jun 26, 2024
sagemathgh-37998: Update conda-lock files, rename macOS conda-lock fi…
82bc2c3 
…les to match CI Conda, remove unexplained duplicate lock files

    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

The renaming is done so that the fix here can take effect on PR runs via
the "CI Fix" mechanism (as changes to the workflow files themselves
cannot take effect).
- Moreover, making arm64 the default platform for macOS makes sense
because all new macOS machines use this platform.

And update by running `.github/workflows/conda-lock-update.py` for all
architectures.

- Workflow matrix variables now contain `-latest`, to add tests for the
macOS x86_64 platform (runner name: `macos-13`)

- Removes some unexplained duplications (both `arm` and `arm64` files
for macOS, both `aarch` and `aarch64` for Linux)

- Fixes sagemath#37997

Author: @mkoeppe, @gmou3

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->

- Depends on sagemath#38033 (split out from here)
- Depends on sagemath#38034 (split out from here)
- Depends on sagemath#38222 (merged here)
    
URL: sagemath#37998
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee
@vbraun vbraun merged commit 440b483 into sagemath:develop Jun 27, 2024
37 of 46 checks passed
@tornaria
Copy link
Contributor

Nothing here explains why this should be a blocker, not even why this should happen at all.

Because we're trying to make a release, and your PR #37884 is not ready.

Come on, #37884 is 100% ready, blame your #38169. But note that updating 4.12.2 to 4.13.1 doesn't need anything special for us (https://github.com/void-linux/void-packages/pull/49571/files#diff-d5e8ac4c14235608656fe702205ba0e985de306ecc14756391643152370bfbd3).

@mkoeppe mkoeppe deleted the reject_gap_4.13 branch July 18, 2024 20:37
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 18, 2024

Please @tornaria. As you know, #37884 is not in a shape to be merged because nobody implemented the proposed solutions to support both the old and the new version (see #37884 (comment)).

@tornaria
Copy link
Contributor

Please @tornaria. As you know, #37884 is not in a shape to be merged because nobody implemented the proposed solutions to support both the old and the new version (see #37884 (comment)).

Please @mkoeppe. As you know, #37884 is 100% ready to run sagemath with gap 4.13.0 or 4.13.1. The reason forhy #38169 is not ready escapes me.

@tornaria
Copy link
Contributor

... and there is nothing here that explains the reason to reject system gap 4.13.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 19, 2024

@tornaria The Release Manager will simply not merge a PR such as #37884 that requires a newer version of a library than what is provided by the Sage distribution -- because he tests with the Sage distribution, the tests will fail, and he'll set it back to "needs work".

So whenever you want to prepare a PR that adds support for a newer version of a library,

  • either find a way to support both the old and the new version (including passing all tests);
  • or combine the PR with the upgrade of the library.

But I'm pretty sure that you know all that. So what's with the "Come on" and "Please"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enriqueartal enriqueartal Awaiting requested review from enriqueartal

@vbraun vbraun Awaiting requested review from vbraun

Assignees

@mkoeppe mkoeppe

Labels
c: build: configure c: packages: standard p: blocker / 1 v: minimal
Projects
None yet
Milestone
sage-10.4
Development

Successfully merging this pull request may close these issues.
4 participants
@mkoeppe @tornaria @vbraun @kwankyu