-
-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build/pkgs/numpy
2.0.1, scipy
1.13.1, cmake
3.30.2, gsl
2.8, meson
1.5.1, meson_python
0.16.0, ninja_build
1.12.1, openblas
0.3.28, pybind11
2.13.1, pythran
0.16.1
#38227
base: develop
Are you sure you want to change the base?
Conversation
build/pkgs/numpy
2.0, scipy
1.13.1, meson
1.4.1, meson_python
0.16.0, pythran
0.16.1build/pkgs/numpy
2.0, scipy
1.13.1, cmake
3.29.5, gsl
2.8, meson
1.4.1, meson_python
0.16.0, ninja_build
1.12.1, openblas
0.3.27, pythran
0.16.1
build/pkgs/numpy
2.0, scipy
1.13.1, cmake
3.29.5, gsl
2.8, meson
1.4.1, meson_python
0.16.0, ninja_build
1.12.1, openblas
0.3.27, pythran
0.16.1build/pkgs/numpy
2.0, scipy
1.13.1, cmake
3.29.5, gsl
2.8, meson
1.4.1, meson_python
0.16.0, ninja_build
1.12.1, openblas
0.3.27, pybind11
2.12.0, pythran
0.16.1
build/pkgs/numpy
2.0, scipy
1.13.1, cmake
3.29.5, gsl
2.8, meson
1.4.1, meson_python
0.16.0, ninja_build
1.12.1, openblas
0.3.27, pybind11
2.12.0, pythran
0.16.1build/pkgs/numpy
2.0, scipy
1.13.1, cmake
3.29.5, contourpy
1.2.1, gsl
2.8, matplotlib
3.9.0, meson
1.4.1, meson_python
0.16.0, ninja_build
1.12.1, openblas
0.3.27, pybind11
2.12.0, pythran
0.16.1
Documentation preview for this PR (built with commit 16eb5e4; changes) is ready! 🎉 |
build/pkgs/numpy
2.0, scipy
1.13.1, cmake
3.29.5, contourpy
1.2.1, gsl
2.8, matplotlib
3.9.0, meson
1.4.1, meson_python
0.16.0, ninja_build
1.12.1, openblas
0.3.27, pybind11
2.12.0, pythran
0.16.1build/pkgs/numpy
2.0.1, scipy
1.13.1, cmake
3.30.1, contourpy
1.2.1, gsl
2.8, matplotlib
3.9.1, meson
1.5.0, meson_python
0.16.0, ninja_build
1.12.1, openblas
0.3.27, pybind11
2.13.1, pythran
0.16.1
build/pkgs/numpy
2.0.1, scipy
1.13.1, cmake
3.30.1, contourpy
1.2.1, gsl
2.8, matplotlib
3.9.1, meson
1.5.0, meson_python
0.16.0, ninja_build
1.12.1, openblas
0.3.27, pybind11
2.13.1, pythran
0.16.1build/pkgs/numpy
2.0.1, scipy
1.13.1, cmake
3.30.2, contourpy
1.2.1, gsl
2.8, matplotlib
3.9.1, meson
1.5.1, meson_python
0.16.0, ninja_build
1.12.1, openblas
0.3.27, pybind11
2.13.1, pythran
0.16.1
I get sage -t --warn-long 69.9 --random-seed=274666681782489637879204037307995713165 src/sage/graphs/generic_graph.py
**********************************************************************
File "src/sage/graphs/generic_graph.py", line 15996, in sage.graphs.generic_graph.GenericGraph.?
Failed example:
(graphs.FruchtGraph()).clustering_coeff(weight=True) # needs networkx
Expected:
{0: 0.3333333333333333, 1: 0.3333333333333333, 2: 0,
3: 0.3333333333333333, 4: 0.3333333333333333,
5: 0.3333333333333333, 6: 0.3333333333333333,
7: 0.3333333333333333, 8: 0, 9: 0.3333333333333333,
10: 0.3333333333333333, 11: 0}
Got:
{0: np.float64(0.3333333333333333),
1: np.float64(0.3333333333333333),
2: 0,
3: np.float64(0.3333333333333333),
4: np.float64(0.3333333333333333),
5: np.float64(0.3333333333333333),
6: np.float64(0.3333333333333333),
7: np.float64(0.3333333333333333),
8: 0,
9: np.float64(0.3333333333333333),
10: np.float64(0.3333333333333333),
11: 0}
**********************************************************************
File "src/sage/graphs/generic_graph.py", line 16006, in sage.graphs.generic_graph.GenericGraph.?
Failed example:
(graphs.FruchtGraph()).clustering_coeff(nodes=[0,1,2], # needs networkx
weight=True)
Expected:
{0: 0.3333333333333333, 1: 0.3333333333333333, 2: 0}
Got:
{0: np.float64(0.3333333333333333), 1: np.float64(0.3333333333333333), 2: 0}
**********************************************************************
1 item had failures:
2 of 1269 in sage.graphs.generic_graph.GenericGraph.?
[3915 tests, 2 failures, 23.88 s]
----------------------------------------------------------------------
sage -t --warn-long 69.9 --random-seed=274666681782489637879204037307995713165 src/sage/graphs/generic_graph.py # 2 doctests failed
---------------------------------------------------------------------- |
I can now answer to this. After Tobias's PR #36982, This may impose a version constraint stricter than necessary on the dependency of sagemath-standard. However, according to Matthias: #37902 (comment), it is dubious whether sagemath-standard gets real harm from the stricter version constraint. Anyway there is no mechanism in sage that can be used to maintain two sets of version constraints, one for sage-the-distribution and one for modularized distributions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working well. LGTM.
The demand by Tobias Diez (https://groups.google.com/g/sage-devel/c/sVcJiJdUxRs/m/oEntIDE9AgAJ), to deviate from the long-standing practice of synchronized version constraints, are out of scope of this upgrade PR. Setting to "disputed". |
+1 from me. |
https://numpy.org/doc/stable/release/2.0.0-notes.html
https://scipy.github.io/devdocs/release/1.13.1-notes.html
Fixes using numpy 2.0 #38242
📝 Checklist
⌛ Dependencies
build/pkgs/setuptools_scm
: Upgrade to 8.1.0, fix dependency typing_extensions, change some packages towheel
#38226 (merged here)