Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create configure --enable-SPKG options also for pip packages #38387

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

mkoeppe
Copy link
Member

@mkoeppe mkoeppe commented Jul 18, 2024

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

Copy link

github-actions bot commented Jul 18, 2024

Documentation preview for this PR (built with commit 2a26ea5; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@mkoeppe mkoeppe force-pushed the configure-enable-pip-packages branch from 8a84b8e to 2f07469 Compare July 25, 2024 12:14
@kwankyu
Copy link
Collaborator

kwankyu commented Jul 30, 2024

I tested with ./configure --enable-pycryptosat. This worked. That is, make installed the package:

[pycryptosat] Installing collected packages: pycryptosat
[pycryptosat] Successfully installed pycryptosat-5.11.21

But the message from ./configure --enable-pycryptosat is not appropriate:

pycparser:                      no; standard, SPKG version 2.22 is already installed
pycryptosat:                    no; optional pip package; use "./sage -i pycryptosat" to install
pygments:                       no; standard, SPKG version 2.18.0 is already installed

This message persists even after make installed pycryptosat successfully.

@mkoeppe
Copy link
Member Author

mkoeppe commented Aug 1, 2024

Right. For pip packages, the Sage distribution does not maintain installation records (other than pip's own records), and the configure script (nor the build system) does not know what is installed.
I'll adjust the messages accordingly.

@mkoeppe mkoeppe force-pushed the configure-enable-pip-packages branch from 524beba to 2a26ea5 Compare August 3, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants