Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add method is_vertex_cut to (di)graphs #38418

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

add method is_vertex_cut to (di)graphs #38418

wants to merge 1 commit into from
+147 −62

Conversation

dcoudert
Copy link
Contributor

This PR answers a query from https://ask.sagemath.org/question/78391/does-sage-have-a-function-to-determine-vertex-cuts/

It adds to (di)graphs a method to check if a set of vertices is a vertex cut of the (di)graph, that is if its removal from the (di)graph increases the number of (strongly) connected components. This generalizes method is_cut_vertex.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@dcoudert dcoudert self-assigned this Jul 24, 2024
@dcoudert dcoudert requested a review from videlec July 24, 2024 16:32
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 24, 2024 •
edited
Loading

Documentation preview for this PR (built with commit 872c66e; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@lichengzhang1
Copy link

For edge versions, a similar problem involves adding a method is_edge_cut to (di)graphs.

@dcoudert
Copy link
Contributor Author

For edge versions, a similar problem involves adding a method is_edge_cut to (di)graphs.

Sure, but this should be done in another PR. This one is large enough.

@dcoudert dcoudert mentioned this pull request Jul 27, 2024
Merged
5 tasks
@dcoudert
Copy link
Contributor Author

dcoudert commented Aug 6, 2024

@fchapoton I need some help here to rebase this branch. I tried to rebase on develop and fix merge conflicts, but push was rejected

MAC-04017247:sage dcoudert$ git push origin HEAD:"graphs/is_vertex_cut"
To https://github.com/dcoudert/sage.git
 ! [rejected]                HEAD -> graphs/is_vertex_cut (non-fast-forward)
error: failed to push some refs to 'https://github.com/dcoudert/sage.git'
hint: Updates were rejected because a pushed branch tip is behind its remote
hint: counterpart. Check out this branch and integrate the remote changes
hint: (e.g. 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.

@fchapoton
Copy link
Contributor

say "thank you" to the recent doc patch-bombe..

I am not sure how to handle that properly ; my only safe strategy is the following :

did you try to click on the "resolve conflicts" button here and fix the conflicts online ?

@fchapoton
Copy link
Contributor

  • are you sure you have the latest develop ?
  • you can use "git push -f" to force the push, but be cautious..

@fchapoton
Copy link
Contributor

il y a des instructions precises quand on clique sur "use the command line"

@dcoudert
Copy link
Contributor Author

dcoudert commented Aug 6, 2024

  • I can't click on "resolve conflicts". It says that "These conflicts are too complex to resolve in the web editor"
  • I have the last develop branch (according my clone on GitHub, and git pull)
  • I don't see any "use the command line" button
  • I will try a forced push...

@dcoudert
Copy link
Contributor Author

dcoudert commented Aug 6, 2024

Thanks @fchapoton, the forced push seems ok.

vbraun pushed a commit to vbraun/sage that referenced this pull request Sep 5, 2024
sagemathgh-38435: add method is_edge_cut to graphs
3dafb02 
    
Similarly to sagemath#38418, this PR adds a method to check whether a set of
edges forms an edge cut of the (di)graph, that is if the removal of
these edges increases the number of (weakly) connected components.


### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#38435
Reported by: David Coudert
Reviewer(s): David Coudert, Kwankyu Lee
vbraun pushed a commit to vbraun/sage that referenced this pull request Sep 6, 2024
sagemathgh-38435: add method is_edge_cut to graphs
6f0d1f6 
    
Similarly to sagemath#38418, this PR adds a method to check whether a set of
edges forms an edge cut of the (di)graph, that is if the removal of
these edges increases the number of (weakly) connected components.


### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#38435
Reported by: David Coudert
Reviewer(s): David Coudert, Kwankyu Lee
vbraun pushed a commit to vbraun/sage that referenced this pull request Sep 8, 2024
sagemathgh-38435: add method is_edge_cut to graphs
002ab2d 
    
Similarly to sagemath#38418, this PR adds a method to check whether a set of
edges forms an edge cut of the (di)graph, that is if the removal of
these edges increases the number of (weakly) connected components.


### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#38435
Reported by: David Coudert
Reviewer(s): David Coudert, Kwankyu Lee
vbraun pushed a commit to vbraun/sage that referenced this pull request Sep 8, 2024
sagemathgh-38435: add method is_edge_cut to graphs
9cb05e6 
    
Similarly to sagemath#38418, this PR adds a method to check whether a set of
edges forms an edge cut of the (di)graph, that is if the removal of
these edges increases the number of (weakly) connected components.


### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#38435
Reported by: David Coudert
Reviewer(s): David Coudert, Kwankyu Lee
vbraun pushed a commit to vbraun/sage that referenced this pull request Sep 10, 2024
sagemathgh-38435: add method is_edge_cut to graphs
5915803 
    
Similarly to sagemath#38418, this PR adds a method to check whether a set of
edges forms an edge cut of the (di)graph, that is if the removal of
these edges increases the number of (weakly) connected components.


### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#38435
Reported by: David Coudert
Reviewer(s): David Coudert, Kwankyu Lee
vbraun pushed a commit to vbraun/sage that referenced this pull request Sep 12, 2024
sagemathgh-38435: add method is_edge_cut to graphs
91f333f 
    
Similarly to sagemath#38418, this PR adds a method to check whether a set of
edges forms an edge cut of the (di)graph, that is if the removal of
these edges increases the number of (weakly) connected components.


### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#38435
Reported by: David Coudert
Reviewer(s): David Coudert, Kwankyu Lee
vbraun pushed a commit to vbraun/sage that referenced this pull request Sep 14, 2024
sagemathgh-38435: add method is_edge_cut to graphs
473a571 
    
Similarly to sagemath#38418, this PR adds a method to check whether a set of
edges forms an edge cut of the (di)graph, that is if the removal of
these edges increases the number of (weakly) connected components.


### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#38435
Reported by: David Coudert
Reviewer(s): David Coudert, Kwankyu Lee
@dcoudert
Copy link
Contributor Author

something went wrong with my last commit, trying to fix a merge conflict with 10.5.beta4.... I'm not sure how to fix that.
Any advice is more than welcome.

@fchapoton
Copy link
Contributor

well, github requires that the branch is rebased on top of the latest develop. If you merge instead, you git these hundreds of commits..

@fchapoton
Copy link
Contributor

more precisely the commit message must look like
```Merge branch 'develop' into my_cool_branch``

@dcoudert
Copy link
Contributor Author

I have restarted a branch on top of 10.5.beta4 with a forced push. It should be ok now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkoeppe mkoeppe mkoeppe left review comments

@videlec videlec Awaiting requested review from videlec

Assignees

@dcoudert dcoudert

Labels
c: graph theory s: needs review v: moderate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dcoudert @lichengzhang1 @fchapoton @mkoeppe