Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loosen tolerance in a few expm() tests #38685

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Loosen tolerance in a few expm() tests #38685

wants to merge 3 commits into from

Commits on Sep 20, 2024

  1. src/sage/matrix/matrix_double_dense.pyx: loosen two test tolerances 

    Change 1r-14 to 5e-14 in the following two examples. This is likely
required because expm() in scipy was rewritten in C.

Example 1:

  File "src/sage/matrix/matrix_double_dense.pyx", line 3666, in
  sage.matrix.matrix_double_dense.Matrix_double_dense.exp
  Failed example:
    A.exp()  # tol 1e-14
  Expected:
    [51.968956198705044  74.73656456700327]
    [112.10484685050491 164.07380304920997]
  Got:
    [51.968956198707595    74.736564567007]
    [112.10484685051048 164.07380304921807]
  Tolerance exceeded in 4 of 4:
    51.968956198705044 vs 51.968956198707595, tolerance 5e-14 > 1e-14
    74.73656456700327 vs 74.736564567007, tolerance 5e-14 > 1e-14
    112.10484685050491 vs 112.10484685051048, tolerance 5e-14 > 1e-14
    164.07380304920997 vs 164.07380304921807, tolerance 5e-14 > 1e-14

Example 2:

  File "src/sage/matrix/matrix_double_dense.pyx", line 3679, in
  sage.matrix.matrix_double_dense.Matrix_double_dense.exp
  Failed example:
    A.exp()   # tol 1e-14
  Expected:
    [51.968956198705044  74.73656456700327]
    [112.10484685050491 164.07380304920997]
Got:
    [51.968956198707595    74.736564567007]
    [112.10484685051048 164.07380304921807]
  Tolerance exceeded in 4 of 4:
    51.968956198705044 vs 51.968956198707595, tolerance 5e-14 > 1e-14
    74.73656456700327 vs 74.736564567007, tolerance 5e-14 > 1e-14
    112.10484685050491 vs 112.10484685051048, tolerance 5e-14 > 1e-14
    164.07380304920997 vs 164.07380304921807, tolerance 5e-14 > 1e-14
    @orlitzky
    orlitzky committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    71ac8a7 View commit details
    Browse the repository at this point in the history

  2. src/sage/matrix/matrix2.pyx: loosen a test tolerance 

    Change 1e-14 to 6e-14 in the following example. This is likely
necessary because expm() in scipy was rewritten in C.

  File "src/sage/matrix/matrix2.pyx", line 15903,
  in sage.matrix.matrix2.Matrix.exp
  Failed example:
    a.change_ring(RDF).exp()  # rel tol 1e-14
  Expected:
    [42748127.31532951 7368259.244159399]
    [234538976.1381042 40426191.45156228]
  Got:
    [ 42748127.31533201  7368259.244159831]
    [234538976.13811788  40426191.45156465]
  Tolerance exceeded in 4 of 4:
    42748127.31532951 vs 42748127.31533201, tolerance 6e-14 > 1e-14
    7368259.244159399 vs 7368259.244159831, tolerance 6e-14 > 1e-14
    234538976.1381042 vs 234538976.13811788, tolerance 6e-14 > 1e-14
    40426191.45156228 vs 40426191.45156465, tolerance 6e-14 > 1e-14
    @orlitzky
    orlitzky committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    13969c3 View commit details
    Browse the repository at this point in the history

  3. src/sage/symbolic/constants_c_impl.pxi: loosen a test tolerance 

    In the following example, we now use 5e-14 instead of 1e-14. This is
likely due to scipy's expm() being rewritten in C:

  File "src/sage/symbolic/constants_c_impl.pxi", line 162, in
  sage.symbolic.constants_c_impl.pxi.E.__pow__
  Failed example:
    e^A  # rel tol 1e-14
  Expected:
    [51.968956198705044  74.73656456700327]
    [112.10484685050491 164.07380304920997]
  Got:
    [51.968956198707595    74.736564567007]
    [112.10484685051048 164.07380304921807]
 Tolerance exceeded in 4 of 4:
    51.968956198705044 vs 51.968956198707595, tolerance 5e-14 > 1e-14
    74.73656456700327 vs 74.736564567007, tolerance 5e-14 > 1e-14
    112.10484685050491 vs 112.10484685051048, tolerance 5e-14 > 1e-14
    164.07380304920997 vs 164.07380304921807, tolerance 5e-14 > 1e-14
    @orlitzky
    orlitzky committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    4a96473 View commit details
    Browse the repository at this point in the history