frontend/i18n: continue... #7864
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haraldschilly
force-pushed
the
i18n-20240920
branch
2 times, most recently
from
97ead4c
to
77e7f30
Compare
haraldschilly
force-pushed
the
i18n-20240920
branch
2 times, most recently
from
19e47fc
to
bc4804c
Compare
…and browser language != en
haraldschilly
force-pushed
the
i18n-20240920
branch
from
bc4804c
to
f23d18a
Compare
haraldschilly
added
PR-needs testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
navigator.language) is not english (starting with "en") AND you never selected a UI language, a banner appears to either select a language or keep it in english. There is also an additional language selector in account→other.... and if selected, there is a confirmation box with a short hint where this can be changed later on.
Checklist: