Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match error when trying to reproduce a failing test case built with TrialsApi.uniqueIds. #71

Closed
sageserpent-open opened this issue Jan 5, 2024 · 5 comments

Comments

@sageserpent-open
Copy link
Owner

sageserpent-open commented Jan 5, 2024

The test support code in the Kinetic Merge repository: MergeTest.simpleMergeTestCases uses trialsApi.uniqueIds.

Trying to reproduce the maximally shrunk failing test case from MergeTest.fullMerge at that Git commit (SHA 65318cdeaaa26ab9467bea7dc61865a14f665641) results in a MatchError in Americium.

scala.MatchError: UniqueId (of class com.sageserpent.americium.generation.UniqueId$)

	at com.sageserpent.americium.TrialsImplementation$$anon$1.apply(TrialsImplementation.scala:103)
	at com.sageserpent.americium.TrialsImplementation$$anon$1.apply(TrialsImplementation.scala:64)

Seen in Americium 1.17.0.

@sageserpent-open
Copy link
Owner Author

sageserpent-open commented Jan 5, 2024

A cursory look at the two interpreters shows that the one in SupplyToSyntaxSkeletalImplementation (used to generate test cases for a nomal run) has a pattern match for UniqueId, whereas the one in TrialsImplementation (used for test case reproduction) does not - clearly an oversight and lack of testing.

The job is to add an example to the existing Scalatest test for test case reproduction, confirm that it fails and then add the missing pattern match to the second interpreter.

@sageserpent-open
Copy link
Owner Author

Done, went out in release 1.18.2, Git commit SHA 53d0ee1.

@sageserpent-open
Copy link
Owner Author

sageserpent-open commented Jan 5, 2024

Drat - forgot to increment the unique id when it is read, this results in an incorrect reproduction in the aforementioned test in the Kinetic Merge repository. Need to bolster the test and do another fix and release cycle, grrr...

sageserpent-open added a commit that referenced this issue Jan 5, 2024
…h more than one unique id in the test case. Test fails, as expected...
sageserpent-open added a commit to sageserpent-open/kineticMerge that referenced this issue Jan 5, 2024
@sageserpent-open
Copy link
Owner Author

Another minor release: 1.18.3, Git commit SHA fd6cf1f.

@sageserpent-open
Copy link
Owner Author

Confirmed that the test in the Kinetic Merge repository now correctly reproduces the maximally shrunk test case.

sageserpent-open added a commit to sageserpent-open/kineticMerge that referenced this issue Jan 6, 2024
sageserpent-open added a commit to sageserpent-open/actinium that referenced this issue Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant