Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not build on illumos #10

Closed
Toasterson opened this issue May 22, 2022 · 7 comments
Closed

Can not build on illumos #10

Toasterson opened this issue May 22, 2022 · 7 comments
Assignees

Comments

@Toasterson
Copy link

Describe The Bug

The users crate has a open PR which is required to build on illumos

To Reproduce

Build this crate on illumos

Link to PR

ogham/rust-users#49

@sagiegurari
Copy link
Owner

i see the PR is open for a long time with no response. any better alternative to that crate?

@Toasterson
Copy link
Author

In your usecase maybe libc crate directly? the users crate is pretty fundamental and seems unmaintained. A request for maintainer change is the only thing I can come up with. crates like whoami use the posix and windows API's directly but also lack illumos support. And the API you are using is pretty much one libc function that could be copied from the users crate.

If I look at https://github.com/ogham/rust-users/blob/master/src/base.rs#L552-L557 one could rip out these two functions and thats all that this crate needs. The incompatible parts are the Os specific extensions that the users crate also supports.

@sagiegurari
Copy link
Owner

i'm thinking i can make it even simpler.... let me investigate it a bit.

@sagiegurari
Copy link
Owner

@Toasterson i think it should be resolved now.

@Toasterson
Copy link
Author

Yeah that definitely resolves the issue. And I think in the context of cargo-make this also adds a nice prefix to the path that should also work on Windows?

@sagiegurari
Copy link
Owner

for windows the scripts are positioned in /fsio/randomfile while in linux/mac/... its at /fsio_/fsio/randomfile
reason is that the temp dir can be shared in linux so i need an upper level folder to be different between users so it can be deleted later on. before, i used the username but now i'm just putting some random string.

@sagiegurari
Copy link
Owner

closing as this is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants