Skip to content

Commit

Permalink
chore: Upgrade ibis to 9.0 (feast-dev#4330)
Browse files Browse the repository at this point in the history
upgrade ibis version

Signed-off-by: tokoko <togurg14@freeuni.edu.ge>
  • Loading branch information
tokoko authored and nick-amaya-sp committed Jul 23, 2024
1 parent e2f7631 commit a4fe277
Show file tree
Hide file tree
Showing 8 changed files with 80 additions and 572 deletions.
7 changes: 2 additions & 5 deletions sdk/python/feast/infra/offline_stores/ibis.py
Original file line number Diff line number Diff line change
Expand Up @@ -335,11 +335,8 @@ def deduplicate(
if created_timestamp_col:
order_by_fields.append(ibis.desc(table[created_timestamp_col]))

table = (
table.group_by(by=group_by_cols)
.order_by(order_by_fields)
.mutate(rn=ibis.row_number())
)
window = ibis.window(group_by=group_by_cols, order_by=order_by_fields, following=0)
table = table.mutate(rn=ibis.row_number().over(window))

return table.filter(table["rn"] == ibis.literal(0)).drop("rn")

Expand Down
Loading

0 comments on commit a4fe277

Please sign in to comment.