Nested Schema Validation #47
Open
+1,093
−188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
another awesome PR from @clarkorz™ Thanks man. Will look as soon as I have a chance, slammed this week. |
|
@mikermcneil will this PR be accepted? it's an excellent contribution! |
|
@clarkorz we're working on a more flexible version of some of the basic type-checking here as part of the machine module in the node-machine project-- let me know what you think! Would be good to figure out a way to share some code between modules |
|
when are you going to merge this? |
Maybe in a few years? 😢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, anchor works only for either type(nested type) or ruleset. But I really need nested schema check which combines type and ruleset (means, any type defined in nested type schema can be replace with a ruleset). This PR add Nested Schema Validation, and the code is based on a copy of
deepMatchType, I only refactor the oldmatchType.jsand changedanchor.prototype.to()slightly. So it should be backward compatible: this PR pass all old anchor tests ,sails#mastertests andwaterline#mastertests, without changes.But to make nested schema validation works,
request.validate()andModel#validate()have to change the way of usinganchor.prototype.to(). The former is quite simple, I'll send a PR onsails. The later is too complex, that's why I ensure it backward compatible.