Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add malloc size check #93

Merged
merged 1 commit into from
Dec 14, 2019
Merged

Add malloc size check #93

merged 1 commit into from
Dec 14, 2019

Conversation

knok
Copy link
Contributor

@knok knok commented Jul 8, 2019

#80 caused by zero-size malloc.

@saitoha saitoha self-requested a review July 12, 2019 14:28
@knok
Copy link
Contributor Author

knok commented Jul 18, 2019

The original code seems size check in rpl_malloc:
https://github.com/saitoha/libsixel/blob/master/converters/malloc_stub.c#L43
and if size equals 0, try to allocate 1 byte instead of 0,but this problem seems to access over this area.

saitoha added a commit that referenced this pull request Dec 14, 2019
@saitoha
Merge PR #93, fixing CVE-2018-19756, Thanks to NOKUBI Takatsugu(@knok)
aac1df6
@saitoha saitoha merged commit d6e34fc into saitoha:master Dec 14, 2019
This was referenced Dec 16, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saitoha saitoha Awaiting requested review from saitoha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@knok @saitoha