Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
- Remove duplication with open-telemetry#186
- Mention about configurable timeout of flush operation
  • Loading branch information
saiya committed Jul 25, 2019
1 parent cdc70d2 commit 9efc8f2
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions specification/performance.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@ Here are the key principles:

Although there are inevitable overhead to achieve monitoring, API should not degrade the end-user application as possible. So that it should not block the end-user application nor consume too much memory resource.

Especially, most telemetry exporters need to call API of servers to export traces. API call operations should be performed in asynchronous I/O or background thread to prevent blocking end-user applications.

See also [Concurrency and Thread-Safety](concurrency.md) if the implementation supports concurrency.

### Tradeoff between non-blocking and memory consumption
Expand Down Expand Up @@ -42,7 +40,7 @@ In a documentation of the language library, it is a good idea to point out that

The language library could block the end-user application when it shut down. On shutdown, it has to flush data to prevent information loss. The language library should support user-configurable timeout if it blocks on shut down.

If the language library supports an explicit flush operation, it could block also.
If the language library supports an explicit flush operation, it could block also. But should support a configurable timeout.

## Documentation

Expand Down

0 comments on commit 9efc8f2

Please sign in to comment.