streamer: Sign TLS cert with validator identity key #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sakridge
force-pushed
the
tpu-quic
branch
28 times, most recently
from
a956697 to
1d27326
Compare
sakridge
force-pushed
the
tpu-quic
branch
5 times, most recently
from
b50c617 to
c7a9629
Compare
sakridge
pushed a commit
that referenced
this pull request
Mar 14, 2024
* Update README.md * ci: update CodeCov report link * ci: update github pr link * ci: rename secondary pipeline * replace org name in .mergify * update channel info link * update dependabot pr link * use anza docker image * delete travis --------- Co-authored-by: Will Hickey <will.hickey@solana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the validator to reuse it's identity key to self-sign the TPU server certificate.
There's a security concern with signing certs directly with the validator key.
We have to make sure that this signing process can never be used to forge consensus message or transaction signatures.
In the future, TPU clients could serve a client cert using the same mechanism too.
This would hopefully allow the validator to apply basic QoS based on node identity, e.g. giving identity keys that have been observed in gossip longer more TPU bandwidth.