Implemented data sending to the device with send periodic #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sale3
reviewed
Sep 9, 2024
| @@ -198,6 +198,31 @@ def update_protocols_on_startup(protocols): | |||
| session.close() | |||
|
|
|||
|
|
|||
| def publish_protocol_message_to_can_module(data): | |||
There was a problem hiding this comment.
Where is the value processing done (multiplire, divisor, offset...)? On Cloud already?
If not, it should be covered on the gateway.
There was a problem hiding this comment.
Resolved issue in latest commit.
… protocol from the device
sale3
requested changes
Sep 11, 2024
src/can_service.py
Outdated
| msg = can.Message( | ||
| arbitration_id=int(hex_string, 16), data=byte_array, is_extended_id=False, is_remote_frame=False | ||
| value += protocol_data_from_db.offset_value | ||
| if protocol_data_from_db.divisor > 0: |
There was a problem hiding this comment.
We should support negative values too.
| byte_array = struct.pack('d', value) | ||
| extracted_value = extract_bits(byte_array, protocol_data_from_db.start_bit, | ||
| protocol_data_from_db.num_bits) | ||
| extracted_double_value = extracted_value / 10.0 |
There was a problem hiding this comment.
Write a comment why there is division by 10.
sale3
approved these changes
Sep 11, 2024
sale3
deleted the
105-gateway-enable-input-can-messages-sending-to-device
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define new message type sent from cloud to gateway for can messages.
Parse the message and send it to CAN python app.
Read the message and, based on type and action (if exists), send data to device with new thread, stop data sending from device and terminate the thread or return current values to cloud so cloud page is update with the latest information.