Code cleanup #112
Merged
Code cleanup #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sale3
previously approved these changes
Sep 11, 2024
…o 107-gateway-cleanup-code-to-delete-existing-hard-coded-logic
… deleted, replaced it with can module
sale3
approved these changes
Sep 11, 2024
novicatepic
deleted the
107-gateway-cleanup-code-to-delete-existing-hard-coded-logic
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logic for three parameters measured should be deleted (from can service, app service and in other places where it is used)
Sensor module should be deleted, since CAN is used for protocol data.
Stats service should be deleted, since it was used to work with three parameters.
Tests from deleted modules should be commented for now (deleted later since that code can be useful to write my own tests)
Three parameters should be recognized based on protocol data name, and in that case only alarm logic should be present and sent to the device.
When sending data to cloud, it is sent as normal protocol data, and on cloud three parameters can be recognized based on their name.