Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Entry widget and secure conversations v2 #1036

Draft
wants to merge 77 commits into
base: development
Choose a base branch
from
Draft

Entry widget and secure conversations v2 #1036

wants to merge 77 commits into from

Conversation

rasmustautsglia
Copy link
Contributor

What was solved?

Release notes:

  • Feature
  • Ignore
  • Release notes (Is it clear from the description here?)
  • Migration guide (If changes are needed for integrator already using the SDK - what needs to be communicated? Add underneath please)

Additional info:

  • Is the feature sufficiently tested? All tests fixed? Necessary unit, acceptance, snapshots added? Check that at least new public classes & methods are covered with unit tests
  • Did you add logging beneficial for troubleshooting of customer issues?
  • Did you add new logging? We would like the logging between platforms to be similar. Refer to Logging from iOS SDKs → Things to consider for newly added logs in Confluence for more information.

Screenshots:

@rasmustautsglia rasmustautsglia changed the title Feature/entry widget and secure conversations v2 Entry widget and secure conversations v2 Sep 9, 2024
@rasmustautsglia rasmustautsglia force-pushed the feature/entry-widget-and-secure-conversations-v2 branch 2 times, most recently from cd21e48 to fa640ff Compare September 23, 2024 18:11
@rasmustautsglia rasmustautsglia changed the base branch from master to development September 25, 2024 07:00
@ykyivskyi-gl ykyivskyi-gl force-pushed the feature/entry-widget-and-secure-conversations-v2 branch from cfb864f to 17349d7 Compare October 8, 2024 08:44
@rasmustautsglia rasmustautsglia force-pushed the feature/entry-widget-and-secure-conversations-v2 branch from cdf1e06 to cac42b4 Compare October 17, 2024 11:07
@igorkravchenko igorkravchenko force-pushed the feature/entry-widget-and-secure-conversations-v2 branch from aed3878 to 0228f93 Compare October 17, 2024 15:49
Base automatically changed from development to master October 18, 2024 12:55
@igorkravchenko igorkravchenko force-pushed the feature/entry-widget-and-secure-conversations-v2 branch from 7a5e1a8 to f4300ab Compare October 18, 2024 14:33
@andrews-moc
Copy link
Contributor

@rasmustautsglia I think the target branch should be changed to 'development', shouldn't it?

@igorkravchenko igorkravchenko force-pushed the feature/entry-widget-and-secure-conversations-v2 branch from f4300ab to ef727e2 Compare October 21, 2024 07:22
@EgorovEI EgorovEI force-pushed the feature/entry-widget-and-secure-conversations-v2 branch 2 times, most recently from 68ade5b to e0349d0 Compare October 22, 2024 11:31
@EgorovEI EgorovEI changed the base branch from master to development October 22, 2024 11:56
@EgorovEI EgorovEI force-pushed the feature/entry-widget-and-secure-conversations-v2 branch from e0349d0 to 6606af7 Compare October 22, 2024 12:06
@igorkravchenko igorkravchenko force-pushed the feature/entry-widget-and-secure-conversations-v2 branch from 9b2e7c1 to 14d76ce Compare November 1, 2024 14:18
@EgorovEI EgorovEI force-pushed the feature/entry-widget-and-secure-conversations-v2 branch from ea35791 to 1ea3ecf Compare November 11, 2024 13:22
Base automatically changed from development to master November 12, 2024 09:19
@EgorovEI EgorovEI force-pushed the feature/entry-widget-and-secure-conversations-v2 branch 2 times, most recently from 50ee073 to d507d17 Compare December 5, 2024 14:43
@EgorovEI EgorovEI changed the base branch from master to development December 5, 2024 14:47
@EgorovEI EgorovEI force-pushed the feature/entry-widget-and-secure-conversations-v2 branch from d507d17 to 37c9a9d Compare December 5, 2024 18:47
@EgorovEI EgorovEI force-pushed the feature/entry-widget-and-secure-conversations-v2 branch from 76c87b1 to c57e113 Compare December 13, 2024 14:00
Base automatically changed from development to master December 17, 2024 15:06
@EgorovEI EgorovEI changed the base branch from master to development December 17, 2024 15:07
@EgorovEI EgorovEI force-pushed the feature/entry-widget-and-secure-conversations-v2 branch from c735b3e to e2ee5e6 Compare December 17, 2024 16:35
BitriseBot and others added 2 commits December 27, 2024 11:27
@ykyivskyi-gl
Update dependencies declared in Podfile and Package.swift
31b9ce2
@rasmustautsglia @ykyivskyi-gl
Add EntryWidget UI
9cf8f00 
This PR adds EntryWidget bottom sheet. In addition it adds the necessary
support files to be able to develop EntryWidget with SwiftUI.

MOB-3477
Egor Egorov and others added 29 commits December 27, 2024 11:28
@ykyivskyi-gl
SecureConversation business logic
19d8ec8 
This commit introduces next logic:
- If pending secure conversation exists, ChatTranscript screen opens and Leave Current Conversation dialog presents. Then if user press Leave, then EngagementCoordinator changes its engagement kind and starts proper flow: Chat/Audio/Video
This commit also adds unit tests.

MOB-3628
@AndriiHorishniiMOC @ykyivskyi-gl
Add disabled unified customization for disabled state for chat messag…
c619ea3 
…e entry

MOB-3762
@igorkravchenko @ykyivskyi-gl
Add snapshot tests for bottom banner
5a91a4c 
Add bottom banner snapshot tests and update bottom banner and send message unavailable banner to take safe are guide into account.

MOB-3718
@ykyivskyi-gl
Add entry point for EntryWidget for Secure Conversation
23e15c3
@ykyivskyi-gl
ViewController refactoring
b3ee803 
This commit improves readability of ViewController in Testing app
@ykyivskyi-gl
Add pending secure messaging logic to EntryWidget
b4eabd5 
This commit adds next logic into EntryWidget.show(in:) method implementation:
- if pending secure messaging exists ChatTranscript screen will be opened.
- otherwise EntryWidget Bottom Sheet will be shown.
Commit also adds unit test.

MOB-3653
@AndriiHorishniiMOC @ykyivskyi-gl
Apply Unified UI for the SC
72481cf 
Rename all RemoteConfiguration properties from secureConversations to secureMessaging.
Apply a chat header RemoteConfiguration to secureTranscriptHeader.

MOB-3818
@rasmustautsglia @ykyivskyi-gl
Change subheadline color In EntryWidget
562fd7f 
According to the design, subheadline needs to be gray
@ykyivskyi-gl
Extend SCv2 logic with unreadMessageCount
dcd5ef7 
This commit introduces:
- `hasPendingInteraction` computed property that indicates either pending secure conversation exists or unread message count > 0;
- this property replaced `pendingConversationExists` value in EntryWidget and EngagementCoordinator
- unit tests

MOB-3821
@AndriiHorishniiMOC @ykyivskyi-gl
Add accessibility identifiers to Entry Widget items
b722127 
MOB-3487
@igorkravchenko @ykyivskyi-gl
Bump up Core SDK version to 2.0.2 and update SC interface
2074820 
Bump up Core SDK version to 2.0.2 and update 'hasPendingSecureConversationStatus' signature to account for callback with 'Result' instead of 'Bool'.

MOB-3842
@ykyivskyi-gl
Show Entry Widget on SC top banner click
7783878
@ykyivskyi-gl
Add Unit and Snapshot tests for top banner on Secure Conversations
96c0eae
@ykyivskyi-gl
Fix memory leak in Chat module
4b07c3f 
This commit introduces:
- Fixing strong reference cycle in ChatView;
- DismissManager struct allowing to take UIKit dismiss completion block execution under control;
- new unit test;
- getting rid of expectation usage in EngagementCoordinator tests.

MOB-3843
@ykyivskyi-gl
Apply unified UI for SC's top banner on ChatView
4601e51
@igorkravchenko @ykyivskyi-gl
Isolate pending interaction logic in separate model
c081584 
Introduce 'PendingInteraction' model to determine pending interaction for SC 2.0.

MOB-3850
@ykyivskyi-gl
Fix strict version in Podfile.lock
91b0ddb
@ykyivskyi-gl
Improve mark as read SC messages
178f47d
@igorkravchenko @ykyivskyi-gl
Address unavailability banner showing up for SC flow
5addc2a 
Hide send message unavailability banner for SC flow.

MOB-3834
@igorkravchenko @ykyivskyi-gl
Update SC availability taking into account 'transferring' state
271356c 
Add 'transferring' and 'engagement.capabilities.text == true' to be used for SC availability.

MOB-3654
@igorkravchenko @ykyivskyi-gl
Create PendingInteraction model after configuration
a2ce534 
Make sure PendingInteraction model is created after configuration to prevent subscription for unread message count and pending SC status from failure, because 'pubsub' is created only when Core SDK is configured.

MOB-3871
@ykyivskyi-gl
Update dependencies declared in Podfile and Package.swift
47273bb
@rasmustautsglia @ykyivskyi-gl
Handle ongoing engagement in EntryWidget
de6b977 
This PR handles ongoing engagement in EntryWidget for both core engagements
and call visualizer.

MOB-3806
@rasmustautsglia @ykyivskyi-gl
Create interface for resuming call visualizer
914730c 
Up until now Call Visualizer screen sharing or video call screen could
only be opened through bubble tap. Entry Widget requires to open Call
Visualizer by a tap on call visualizer media type, if CV session is ongoing. This PR allows to do just that, by providing an interface to
resume the view.

MOB-3887
@rasmustautsglia @ykyivskyi-gl
Add a state property to determine resume behavior
a7559b4 
If video call and screensharing were not active in Call Visualizer session
calling resume() resulted in screen sharing view being opened. An unexpected behavior. To make it much more readable, state property was
introduced.

In addition, some code was moved around to make the class more readable.
@igorkravchenko @ykyivskyi-gl
Fill area under message entry with same bg color as message entry
93b9644 
With recent changes for SC 2.0 design, area under message entry must be of the same color as message entry background color.

MOB-3889
@ykyivskyi-gl
Handle follow_up end reason
0e2e5ef 
This commit adds handling of `follow_up` end reason the same way as `operator_hung_up`

MOB-3900
@ykyivskyi-gl
Fix keeping wrong interactor state after CV engagement
2245426 
MOB-3901
@ykyivskyi-gl
Fix handling engagement ended flow
fdaf96c 
This commit introduces `endedEngagement` property in Interactor for storing engagement ended by operator to fetch a survey

MOB-3897
@ykyivskyi-gl ykyivskyi-gl force-pushed the feature/entry-widget-and-secure-conversations-v2 branch from ee51db8 to fdaf96c Compare December 27, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rasmustautsglia @andrews-moc @ykyivskyi-gl @igorkravchenko @AndriiHorishniiMOC