Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling engagement ended flow #1169

Conversation

EgorovEI
Copy link
Contributor

MOB-3897

What was solved?
This PR introduces endedEngagement property in Interactor for storing engagement ended by operator to fetch a survey

Release notes:

  • Feature
  • Ignore
  • Release notes (Is it clear from the description here?)
  • Migration guide (If changes are needed for integrator already using the SDK - what needs to be communicated? Add underneath please)

Additional info:

  • Is the feature sufficiently tested? All tests fixed? Necessary unit, acceptance, snapshots added? Check that at least new public classes & methods are covered with unit tests
  • Did you add logging beneficial for troubleshooting of customer issues?
  • Did you add new logging? We would like the logging between platforms to be similar. Refer to Logging from iOS SDKsThings to consider for newly added logs in Confluence for more information.

This commit introduces `endedEngagement` property in Interactor for storing engagement ended by operator to fetch a survey

MOB-3897
Copy link
Contributor

@ykyivskyi-gl ykyivskyi-gl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a small note, we keep expanding the state of interactor, seems that it is good candidate for refactoring.

@EgorovEI
Copy link
Contributor Author

LGTM. Just a small note, we keep expanding the state of interactor, seems that it is good candidate for refactoring.

@ykyivskyi-gl thanks for bringing this reasonable point. Since refactoring requires additional team discussion and preparations, I would keep it as is for now. Now it works well, but still would be good to refactor it in near future. I created the ticket for that and assigned to me.

@EgorovEI EgorovEI merged commit ee51db8 into feature/entry-widget-and-secure-conversations-v2 Dec 27, 2024
8 checks passed
@EgorovEI EgorovEI deleted the bug/MOB-3897-engagement-ended-flow branch December 27, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants