Update playwright/tests/giftCards.spec.ts

Co-authored-by: Wojciech Mista <wojciech.mista@hotmail.com>
saleor · May 10, 2024 · 3e26163 · 3e26163
1 parent d449870
commit 3e26163
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/playwright/pages/dialogs/issueGiftCardDialog.ts b/playwright/pages/dialogs/issueGiftCardDialog.ts
@@ -8,7 +8,7 @@ export class IssueGiftCardDialog extends BasePage {
     readonly expiryPeriodAmountInput = page.locator('[name="expiryPeriodAmount"]'),
     readonly tagsInput = page.getByTestId("gift-card-tag-select-field").locator("input"),
     readonly cardCode = page.getByTestId("cardCode"),
-
+    readonly giftCardExpireFields = page.getByTestId("gift-card-expire-data-fields"),
     readonly sendToCustomerCheckbox = page
       .getByTestId("send-to-customer-section")
       .locator('input[type="checkbox"]'),
@@ -71,6 +71,8 @@ export class IssueGiftCardDialog extends BasePage {
 
   async clickSendExpireDateCheckbox() {
     await this.sendExpireDateCheckbox.click();
+    await expect(this.sendExpireDateCheckbox.isChecked()).toBeTruthy();
+    await this.giftCardExpireFields.waitFor({ state: "attached" });
   }
 
   async clickRequiresActivationCheckbox() {

diff --git a/playwright/tests/giftCards.spec.ts b/playwright/tests/giftCards.spec.ts
@@ -48,8 +48,8 @@ test("TC: SALEOR_106 Issue gift card with specific customer and expiry date @e2e
   await giftCardsPage.issueGiftCardDialog.typeExpiryPeriodAmount("2");
   await giftCardsPage.issueGiftCardDialog.clickSendToCustomerCheckbox();
   await giftCardsPage.issueGiftCardDialog.selectCustomer("e2e-customer to-be-activated");
-  await giftCardsPage.issueGiftCardDialog.clickIssueButton(),
-    await expect(giftCardsPage.issueGiftCardDialog.cardCode).toBeVisible();
+  await giftCardsPage.issueGiftCardDialog.clickIssueButton();
+  await expect(giftCardsPage.issueGiftCardDialog.cardCode).toBeVisible();
 
   const code = (await giftCardsPage.issueGiftCardDialog.cardCode.innerText()).slice(-4);
 

diff --git a/src/giftCards/GiftCardCreateDialog/GiftCardCreateExpirySelect/GiftCardCreateExpirySelect.tsx b/src/giftCards/GiftCardCreateDialog/GiftCardCreateExpirySelect/GiftCardCreateExpirySelect.tsx
@@ -95,7 +95,7 @@ const GiftCardCreateExpirySelect: React.FC<GiftCardCreateExpirySelectProps> = ({
           )}
 
           {expiryType === "EXPIRY_PERIOD" && (
-            <div className={classes.periodField}>
+            <div data-test-id="gift-card-expire-data-fields" className={classes.periodField}>
               <TimePeriodField
                 isError={!!errors?.expiryDate}
                 helperText={getGiftCardErrorMessage(errors?.expiryDate, intl)}