Skip to content

Commit

Permalink
Allow to show 0 value in price fied (#5180)
Browse files Browse the repository at this point in the history
* Show 0 value in ProductVariantPrice

* Add tests

* Add changeset
  • Loading branch information
poulch committed Sep 30, 2024
1 parent 350194c commit c330ade
Show file tree
Hide file tree
Showing 3 changed files with 96 additions and 2 deletions.
5 changes: 5 additions & 0 deletions .changeset/slow-mangos-beg.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"saleor-dashboard": patch
---

You can now provide 0 variant price value during product creation
Original file line number Diff line number Diff line change
@@ -0,0 +1,87 @@
import { ChannelData } from "@dashboard/channels/utils";
import { ThemeWrapper } from "@test/themeWrapper";
import { fireEvent, render, screen } from "@testing-library/react";
import React from "react";

import { ProductVariantPrice } from "./ProductVariantPrice";

const wrapper = ({ children }: { children: React.ReactNode }) => (
<ThemeWrapper>{children}</ThemeWrapper>
);

jest.mock("react-intl", () => ({
useIntl: jest.fn(() => ({
formatMessage: jest.fn(x => x.defaultMessage),
})),
defineMessages: jest.fn(x => x),
FormattedMessage: ({ defaultMessage }: { defaultMessage: string }) => <>{defaultMessage}</>,
}));

describe("ProductVariantPrice", () => {
it("should render not assign info text when variant is not assigned to any channel", () => {
// Arrange
render(<ProductVariantPrice errors={[]} productVariantChannelListings={[]} />, { wrapper });

// Assert
expect(
screen.getByText(
"Assign this variant to a channel in the product channel manager to define prices",
),
).toBeInTheDocument();
});

it("should allow to display 0 value", async () => {
// Arrange
const listing = [
{
id: "1",
currency: "USD",
price: 0,
preorderThreshold: 0,
},
] as unknown as ChannelData[];

render(<ProductVariantPrice errors={[]} productVariantChannelListings={listing} />, {
wrapper,
});

// Assert
expect(screen.getByTestId("price-field")).toHaveValue(0);
});

it("should allow to set price value", () => {
// Arrange
const onChange = jest.fn();
const listing = [
{
id: "1",
currency: "USD",
price: "",
preorderThreshold: 0,
},
] as unknown as ChannelData[];

render(
<ProductVariantPrice
errors={[]}
productVariantChannelListings={listing}
onChange={onChange}
/>,
{
wrapper,
},
);

const input = screen.getByTestId("price-field");

// Act
fireEvent.change(input, { target: { value: 0 } });

// Assert
expect(onChange).toHaveBeenCalledWith("1", {
price: 0,
preorderThreshold: 0,
costPrice: undefined,
});
});
});
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ export const ProductVariantPrice: React.FC<ProductVariantPriceProps> = props =>
priceApiError ? getProductErrorMessage(priceApiError, intl) : ""
}
name={fieldName}
value={listing.price || ""}
value={listing.price ?? ""}
currencySymbol={listing.currency}
onChange={e =>
onChange(listing.id, {
Expand All @@ -159,6 +159,7 @@ export const ProductVariantPrice: React.FC<ProductVariantPriceProps> = props =>
}
disabled={loading}
required
data-test-id="price-field"
/>
) : (
<Skeleton />
Expand All @@ -172,7 +173,7 @@ export const ProductVariantPrice: React.FC<ProductVariantPriceProps> = props =>
})}
error={!!costPriceError}
name={`${listing.id}-channel-costPrice`}
value={listing.costPrice || ""}
value={listing.costPrice ?? ""}
currencySymbol={listing.currency}
onChange={e =>
onChange(listing.id, {
Expand All @@ -183,6 +184,7 @@ export const ProductVariantPrice: React.FC<ProductVariantPriceProps> = props =>
}
disabled={loading}
hint={costPriceError ? getProductErrorMessage(costPriceError, intl) : ""}
data-test-id="cost-price-field"
/>
) : (
<Skeleton />
Expand Down

0 comments on commit c330ade

Please sign in to comment.