Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timeouts ensures that the workflow will automatically terminate jobs that are taking too long #5161

Merged
merged 2 commits into from
Sep 13, 2024
Merged

Add timeouts ensures that the workflow will automatically terminate jobs that are taking too long #5161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c47949
Add timeouts for the workflow
michalina-graczyk Sep 12, 2024
a052673
Create perfect-feet-sneeze.md
michalina-graczyk Sep 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/perfect-feet-sneeze.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"saleor-dashboard": patch
---

Implementing timeouts ensures the workflow automatically terminates jobs taking too long, improving resource utilization and avoiding potential workflow hangs.
18 changes: 11 additions & 7 deletions .github/workflows/run-tests-on-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,14 @@ on:
TESTS_CONCLUSION:
value: ${{ jobs.tests-complete.outputs.TESTS_CONCLUSION }}
description: conclusion of tests
RUN_URL:
RUN_URL:
value: "${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}"
description: Url to job run

jobs:
add-check-and-prepare-instance:
runs-on: ubuntu-latest
timeout-minutes: 30
env:
VERSION: ${{inputs.VERSION}}
CUSTOM_VERSION: ${{inputs.CUSTOM_VERSION}}
Expand Down Expand Up @@ -130,9 +131,10 @@ jobs:
if: needs.add-check-and-prepare-instance.outputs.FRAMEWORK == '"cypress"'
needs: add-check-and-prepare-instance
runs-on: ubuntu-22.04
container:
timeout-minutes: 30
container:
image: cypress/browsers:node18.12.0-chrome106-ff106
options: --user 1001
options: --user 1001
strategy:
fail-fast: false
matrix:
Expand Down Expand Up @@ -172,7 +174,7 @@ jobs:
mailpitUrl: ${{ secrets.CYPRESS_MAILPITURL }}
stripeSecretKey: ${{ secrets.STRIPE_SECRET_KEY }}
stripePublicKey: ${{ secrets.STRIPE_PUBLIC_KEY }}
cypressGrepTags: ${{steps.set-tag-for-tests.outputs.result}}
cypressGrepTags: ${{steps.set-tag-for-tests.outputs.result}}
split: ${{ strategy.job-total }}
splitIndex: ${{ strategy.job-index }}
commitInfoMessage: All tests triggered via ${{ github.event_name}} on ${{ steps.get-env-uri.outputs.ENV_URI }}
Expand All @@ -189,6 +191,7 @@ jobs:
run-pw-tests:
runs-on: ubuntu-22.04
needs: "add-check-and-prepare-instance"
timeout-minutes: 30
if: needs.add-check-and-prepare-instance.outputs.FRAMEWORK == '"playwright"'
strategy:
fail-fast: false
Expand All @@ -211,7 +214,7 @@ jobs:
MAILPITURL: ${{ secrets.MAILPITURL }}
URL_TO_RUN: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}
PW_WORKERS: ${{ vars.PW_WORKERS }}
PW_RETRIES: ${{ vars.PW_RETRIES }}
PW_RETRIES: ${{ vars.PW_RETRIES }}
PROJECT: "e2e apps-e2e"

- name: submit-results-to-testmo
Expand All @@ -227,6 +230,7 @@ jobs:
!cancelled() && always()
needs: ["add-check-and-prepare-instance", "run-cy-tests", "run-pw-tests"]
runs-on: ubuntu-22.04
timeout-minutes: 30
outputs:
TESTS_CONCLUSION: "${{ steps.send-slack-message.outputs.status }}"
steps:
Expand Down Expand Up @@ -274,7 +278,7 @@ jobs:
--environment "$ENVIRONMENT" \
--url_to_action "$URL_TO_ACTION" \
--ref_name "$REF_NAME" \
--additional_title "$ADDITIONAL_TITLE"
--additional_title "$ADDITIONAL_TITLE"

- id: update-check
if: always() && ${{ needs.add-check-and-prepare-instance.outputs.CHECK_ID }}
Expand Down
Loading