Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup feature flags #5190

Merged
merged 16 commits into from
Oct 8, 2024
Merged

Cleanup feature flags #5190

merged 16 commits into from
Oct 8, 2024

Conversation

poulch
Copy link
Member

@poulch poulch commented Oct 1, 2024

What type of PR is this?

  • 💅 Refactor
  • 🌟 Feature
  • 🔥 Bug Fix
  • 🔩 Maintenance
  • 🛠 Workflow CI/CD changes

Related Issues or Documents

  • closes #

Usage Instructions, Screenshots, Recordings

Have you written tests?

  • Yes!
  • No... here is why: Writing tests are mandatory, please replace this text with why test are not included in this PR

[Optional] Description

Copy link

changeset-bot bot commented Oct 1, 2024

🦋 Changeset detected

Latest commit: 85a88e7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
saleor-dashboard Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot temporarily deployed to pr-5190 October 1, 2024 14:04 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5190 October 1, 2024 19:54 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5190 October 2, 2024 08:00 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5190 October 2, 2024 09:04 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5190 October 2, 2024 10:56 Destroyed
@poulch poulch marked this pull request as ready for review October 2, 2024 11:04
@poulch poulch requested a review from a team as a code owner October 2, 2024 11:04
Cloud11PL
Cloud11PL previously approved these changes Oct 2, 2024
src/orders/views/OrderList/filters.test.ts Outdated Show resolved Hide resolved
src/orders/views/OrderList/filters.ts Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pr-5190 October 4, 2024 09:29 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5190 October 8, 2024 13:18 Destroyed
@poulch poulch requested a review from Cloud11PL October 8, 2024 13:19
@poulch poulch merged commit df29edc into main Oct 8, 2024
14 of 15 checks passed
@poulch poulch deleted the merx-973-enable-ff-and-remove-old-code branch October 8, 2024 13:55
poulch added a commit that referenced this pull request Oct 11, 2024
* Enable discount rules ff

* Remove order and product filtering ff

* Refactor ListFiler props to split by new and old filters

* Remove product_filters flag

* Remove order_filters flag

* Fix types

* Fix ListFilters typing

* Remove dead code in  product list

* Remove dead code in  order list

* Update snapshots

* Extract messages

* Remove not used queries

* Add changeset

* cleanup test

* Add todo comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants