Improve backlink in order details and draft order details #5193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 17a2669 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
poulch
previously approved these changes
Oct 2, 2024
| replace?: boolean; | ||
| preserveQs?: boolean; | ||
| resetScroll?: boolean; | ||
| state?: Record<string, unknown>; |
There was a problem hiding this comment.
question: can't we take this props type from react-router?
There was a problem hiding this comment.
state has unknown type, it can be anything
poulch
approved these changes
Oct 3, 2024
7 tasks
andrzejewsky
approved these changes
Oct 11, 2024
poulch
added a commit
that referenced
this pull request
Oct 23, 2024
* improve backlink in order details * fix tests * pass navigator opts to datagrid * make hook generic * fix ts * fix test --------- Co-authored-by: Paweł Chyła <chyla1988@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Related Issues or Documents
Usage Instructions, Screenshots, Recordings
CleanShot.2024-10-02.at.11.55.30.mp4
Have you written tests?
[Optional] Description