Skip to content
This repository has been archived by the owner on Jul 14, 2022. It is now read-only.

Commit

Permalink
Add tslint check to CI
Browse files Browse the repository at this point in the history
  • Loading branch information
piotrgrundas committed Jan 8, 2019
1 parent a91d901 commit 50499d8
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 5 deletions.
3 changes: 3 additions & 0 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ jobs:
- run:
name: Install dependencies
command: npm install
- run:
name: Run tslint
command: npm run tslint
- run:
name: Build application
command: npm run build
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,4 @@ Storefront UX improvements, remove signup to newsletter #182 by @piotrgrundas
Fix two line titles breaking fatured carousel, product page improvements #184 by @piotrgrundas
Allow numbers in product, category & collection urls #185 by @piotrgrundas
Add OpenGraph and Meta tags, minor UI improvements #191 by @piotrgrundas
Add tslint check in the CI, ability to change cart quantity, fix error after removing item from the cart #194 by @piotrgrundas
3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@
"watch": "webpack -d --watch",
"storybook": "start-storybook -p 9001 -c src/storybook/ -s src/",
"codegen": "apollo codegen:generate --target=typescript types",
"codegen-watch": "npm run codegen -- --watch"
"codegen-watch": "npm run codegen -- --watch",
"tslint": "tslint 'src/**/*.ts?(x)'"
}
}
4 changes: 2 additions & 2 deletions src/components/SearchOverlay/SearchOverlay.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,10 @@ import * as React from "react";
import { Link, RouteComponentProps, withRouter } from "react-router-dom";
import ReactSVG from "react-svg";

import { Button, DebounceChange, Loader, TextField } from "..";
import { Button, Loader } from "..";
import { maybe } from "../../core/utils";
import { searchUrl } from "../App/routes";
import { DebouncedTextField } from "../Debounce";
import { Error } from "../Error";
import NetworkStatus from "../NetworkStatus";
import { OfflinePlaceholder } from "../OfflinePlaceholder";
Expand All @@ -17,7 +18,6 @@ import NothingFound from "./NothingFound";
import ProductItem from "./ProductItem";
import { TypedSearchResults } from "./queries";
import { SearchResults } from "./types/SearchResults";
import { DebouncedTextField } from "../Debounce";

const closeSvg = require("../../images/x.svg");
const searchSvg = require("../../images/search.svg");
Expand Down
3 changes: 2 additions & 1 deletion tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
"jsx": "react",
"lib": ["es2017", "dom", "esnext"],
"sourceMap": true,
"target": "es6"
"target": "es6",
"noUnusedLocals": false
}
}
1 change: 0 additions & 1 deletion tslint.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
"no-implicit-dependencies": [true, "dev"],
"no-shadowed-variable": false,
"no-submodule-imports": [true],
"no-unused-variable": true,
"no-var-requires": false
}
}

0 comments on commit 50499d8

Please sign in to comment.