This repository has been archived by the owner on Jul 14, 2022. It is now read-only.
Add add animation after adding to cart #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotrgrundas
commented
Dec 14, 2018
| &-enter { | ||
| opacity: 0; | ||
|
|
||
| @at-root #{&}#{&}-active { |
There was a problem hiding this comment.
Results in .xxx__action--fade-enter.xxx__action--fade-enter-active
dominik-zeglen
approved these changes
Dec 14, 2018
piotrgrundas
force-pushed
the
138/add_to_cart_indicator
branch
2 times, most recently
from
0d3efd5
to
4d04302
Compare
There was a problem hiding this comment.
Shouldn't we disable the button when the "Added" label is rendered? Now I'm able to click on the "added" label constantly, but I think a better experience would be to block the button and wait until it says "Add to cart" again before I can continue. Not sure, maybe should be discussed with @pwgryglak.
|
@maarcingebala |
piotrgrundas
force-pushed
the
138/add_to_cart_indicator
branch
3 times, most recently
from
e7f4662
to
eb7747b
Compare
piotrgrundas
force-pushed
the
138/add_to_cart_indicator
branch
from
eb7747b
to
e64b291
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #138