Skip to content
This repository has been archived by the owner on Jul 14, 2022. It is now read-only.

Collection view, categories pagination, thumbnail update #178

Merged
merged 3 commits into from
Dec 28, 2018
Merged

Collection view, categories pagination, thumbnail update #178

merged 3 commits into from
Dec 28, 2018

Conversation

piotrgrundas
Copy link
Contributor

@piotrgrundas piotrgrundas commented Dec 21, 2018 •
edited by maarcingebala
Loading

Resolves #128 #85 #172

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. The changes are tested.
  4. The code is documented (docstrings, project documentation).
  5. Changes are mentioned in the changelog.

@piotrgrundas piotrgrundas added the wip Work in progress label Dec 21, 2018
@piotrgrundas piotrgrundas changed the title [WIP] Extracted category stuff Collection view, categories pagination, thumbnail update Dec 23, 2018
@piotrgrundas piotrgrundas force-pushed the 128/collections_view branch 2 times, most recently from 2132af0 to d87f27e Compare December 24, 2018 08:31
@piotrgrundas piotrgrundas requested review from dominik-zeglen and maarcingebala and removed request for dominik-zeglen December 27, 2018 08:15
@piotrgrundas piotrgrundas force-pushed the 128/collections_view branch 2 times, most recently from bef52bf to 404f740 Compare December 27, 2018 12:09
@piotrgrundas piotrgrundas removed the wip Work in progress label Dec 28, 2018
@maarcingebala maarcingebala merged commit 4086207 into master Dec 28, 2018
@maarcingebala maarcingebala deleted the 128/collections_view branch December 28, 2018 10:44
@maarcingebala maarcingebala mentioned this pull request Dec 28, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maarcingebala maarcingebala maarcingebala left review comments

@dominik-zeglen dominik-zeglen Awaiting requested review from dominik-zeglen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@piotrgrundas @maarcingebala