This repository has been archived by the owner on Jul 14, 2022. It is now read-only.
Custom Select #312
Merged
Custom Select #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlicjaSzu
force-pushed
the
bumb_react_version
branch
from
022e8c7
to
aee3aae
Compare
AlicjaSzu
force-pushed
the
feature/custom-select
branch
from
992cc8e
to
a04c8ad
Compare
piotrgrundas
suggested changes
May 6, 2019
src/components/Form/index.tsx
Outdated
| @@ -164,7 +164,7 @@ class Form extends React.Component<FormProps, FormState> { | |||
| event.preventDefault(); | |||
| } | |||
| }); | |||
| } else if (child.type === SelectField) { | |||
| } else if (child.type === SelectField || Select) { | |||
There was a problem hiding this comment.
Probably mistake, and should be sth like [SelectField, Select].includes(child.type)
piotrgrundas
approved these changes
May 7, 2019
| <p className="select__option select__option--disabled" key="no-option"> | ||
| {"No Options"} | ||
| </p> | ||
| ); |
There was a problem hiding this comment.
I think this should placed directly in SelectOptionsList.
|
I believe this closes #236? |
piotrgrundas
approved these changes
May 8, 2019
mateuszkula
approved these changes
May 8, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to merge this change because...
fixes #236
Screenshots
Pull Request Checklist