Skip to content
This repository has been archived by the owner on Jul 14, 2022. It is now read-only.

Custom Select #312

Merged
merged 14 commits into from
May 8, 2019
Merged

Custom Select #312

merged 14 commits into from
May 8, 2019

Conversation

AlicjaSzu
Copy link
Contributor

@AlicjaSzu AlicjaSzu commented May 6, 2019

I want to merge this change because...

fixes #236

  • create custom Select component (with autofill functionality)
  • create useClickedOutside
  • add Select to form

Screenshots

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. The changes are tested.
  4. The code is documented (docstrings, project documentation).
  5. Changes are mentioned in the changelog.

@AlicjaSzu AlicjaSzu self-assigned this May 6, 2019
@@ -164,7 +164,7 @@ class Form extends React.Component<FormProps, FormState> {
event.preventDefault();
}
});
} else if (child.type === SelectField) {
} else if (child.type === SelectField || Select) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably mistake, and should be sth like [SelectField, Select].includes(child.type)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

src/components/Select/types.ts Outdated Show resolved Hide resolved
src/components/Select/scss/index.scss Outdated Show resolved Hide resolved
src/components/Select/scss/index.scss Outdated Show resolved Hide resolved
src/components/Select/scss/index.scss Show resolved Hide resolved
src/components/Select/scss/index.scss Show resolved Hide resolved
src/components/Select/Select.tsx Outdated Show resolved Hide resolved
<p className="select__option select__option--disabled" key="no-option">
{"No Options"}
</p>
);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should placed directly in SelectOptionsList.

@NyanKiyoshi
Copy link
Member

I believe this closes #236?

@salwator salwator merged commit 1712526 into bumb_react_version May 8, 2019
@salwator salwator deleted the feature/custom-select branch May 8, 2019 12:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants