Skip to content
This repository has been archived by the owner on Jul 14, 2022. It is now read-only.

Size picker component #425

Merged
merged 13 commits into from
Aug 2, 2019
Merged

Size picker component #425

merged 13 commits into from
Aug 2, 2019

Conversation

bogdal
Copy link
Contributor

@bogdal bogdal commented Aug 1, 2019 •
edited
Loading

This PR adds SizeOverlay component:

image

Screenshots

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. The changes are tested.
  4. The code is documented (docstrings, project documentation).
  5. Changes are mentioned in the changelog.

@bogdal bogdal self-assigned this Aug 1, 2019
@bogdal bogdal marked this pull request as ready for review August 1, 2019 20:09
@bogdal bogdal requested review from jwm0 and mateuszkula August 1, 2019 20:09
@bogdal bogdal changed the title Size component Size picker component Aug 1, 2019
jwm0
jwm0 reviewed Aug 2, 2019
View reviewed changes
src/@next/components/atoms/Icon/Icon.tsx Outdated Show resolved Hide resolved
src/@next/components/atoms/Icon/Icon.tsx Outdated Show resolved Hide resolved
src/@next/components/atoms/Icon/definitions.ts Outdated Show resolved Hide resolved
src/@next/components/atoms/Icon/definitions.ts Show resolved Hide resolved
@bogdal bogdal requested a review from jwm0 August 2, 2019 09:20
@bogdal bogdal merged commit ea6f214 into master Aug 2, 2019
@bogdal bogdal deleted the size-overlay branch August 2, 2019 09:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jwm0 jwm0 jwm0 approved these changes

@mateuszkula mateuszkula Awaiting requested review from mateuszkula

Assignees

@bogdal bogdal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bogdal @jwm0