Skip to content
This repository has been archived by the owner on Jul 14, 2022. It is now read-only.

Ordinary conditional checks when no data exist to make storefront works #551

Merged
merged 3 commits into from
Jan 7, 2020
Merged

Ordinary conditional checks when no data exist to make storefront works #551

merged 3 commits into from
Jan 7, 2020

Conversation

orzechdev
Copy link
Contributor

@orzechdev orzechdev commented Dec 27, 2019 •
edited
Loading

I want to merge this change because it should fix #508.

Screenshots

When no data exist in the database:

Zrzut ekranu 2019-12-27 o 17 53 24

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. The changes are tested.
  4. The code is documented (docstrings, project documentation).
  5. Changes are mentioned in the changelog.

@maarcingebala maarcingebala merged commit be60dd2 into master Jan 7, 2020
@maarcingebala maarcingebala deleted the fix/crash_on_empty_database branch January 7, 2020 08:01
@maarcingebala maarcingebala mentioned this pull request Jan 7, 2020
Closed
@orzechdev orzechdev mentioned this pull request Feb 21, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tomaszszymanski129 tomaszszymanski129 tomaszszymanski129 left review comments

@maarcingebala maarcingebala maarcingebala approved these changes

@jwm0 jwm0 Awaiting requested review from jwm0

@mateuszkula mateuszkula Awaiting requested review from mateuszkula

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

saleor-storefront doesn't work without data in saleor database
3 participants
@orzechdev @maarcingebala @tomaszszymanski129