This repository has been archived by the owner on Jul 14, 2022. It is now read-only.
Preload css for Inter font #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for saleor-storefront-stage processing. Building with commit ad94e00 https://app.netlify.com/sites/saleor-storefront-stage/deploys/5e57b00358ac5d000807b3a3 |
mateuszkula
approved these changes
Feb 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to merge this change because... it adds preconnect to fetch css file describing required fonts. It will cause establish early connections to that file, what might be used in future rendering without blocking it due to required connection establishment.
Another improvement would be moving font source imports to Google fonts, although it is not yet available there due to not full support of this font rendering in modern browsers - google/fonts#1908 (comment) - we might expect it in the future.