Skip to content
This repository has been archived by the owner on Jul 14, 2022. It is now read-only.

Hoist payment gateways for the whole checkout #828

Merged
merged 3 commits into from
Aug 7, 2020

Conversation

orzechdev
Copy link
Contributor

@orzechdev orzechdev commented Aug 3, 2020

I want to merge this change because... it makes payment gateways persisted for all the checkout steps and hides them through CSS if they shouldn't be displayed.

Screenshots

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. The changes are tested.
  4. The code is documented (docstrings, project documentation).
  5. Changes are mentioned in the changelog.

Test Environment Config

API_URI=https://master.staging.saleor.rocks/graphql/

@github-actions github-actions bot temporarily deployed to refactor-gateways-hoisting August 3, 2020 11:37 Inactive
@patrys
Copy link
Member

patrys commented Aug 3, 2020

@github-actions github-actions bot temporarily deployed to refactor-gateways-hoisting August 3, 2020 17:02 Inactive
@github-actions github-actions bot temporarily deployed to refactor-gateways-hoisting August 5, 2020 09:11 Inactive
@lgtm-com

This comment has been minimized.

@github-actions github-actions bot temporarily deployed to refactor-gateways-hoisting August 6, 2020 08:20 Inactive
@github-actions github-actions bot temporarily deployed to refactor-gateways-hoisting August 6, 2020 08:49 Inactive
@orzechdev orzechdev marked this pull request as ready for review August 6, 2020 12:11
@orzechdev orzechdev merged commit c9e7a1c into master Aug 7, 2020
@orzechdev orzechdev deleted the refactor/gateways-hoisting branch August 7, 2020 14:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants