Skip to content
This repository has been archived by the owner on Jul 14, 2022. It is now read-only.

Add default value to product item category in case none is provided #928

Merged
merged 6 commits into from
Oct 23, 2020

Conversation

bmigirl
Copy link

@bmigirl bmigirl commented Oct 23, 2020

I want to merge this change because it fixes issue when searching for a product that has no category and the app crashes

SALEOR-1398

Screenshots

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. The changes are tested.
  4. The code is documented (docstrings, project documentation).
  5. Changes are mentioned in the changelog.

Test Environment Config

API_URI=https://master.staging.saleor.rocks/graphql/

@github-actions github-actions bot temporarily deployed to fix-crash-on-search-for-products-without-category October 23, 2020 08:32 Inactive
@github-actions github-actions bot temporarily deployed to storybook fix-crash-on-search-for-products-without-category October 23, 2020 08:32 Inactive
@github-actions github-actions bot temporarily deployed to fix-crash-on-search-for-products-without-category October 23, 2020 08:34 Inactive
@github-actions github-actions bot temporarily deployed to storybook fix-crash-on-search-for-products-without-category October 23, 2020 08:34 Inactive
@dominik-zeglen
Copy link
Contributor

Could you add story for this case?

@patrys
Copy link
Member

patrys commented Oct 23, 2020

@github-actions github-actions bot temporarily deployed to fix-crash-on-search-for-products-without-category October 23, 2020 11:08 Inactive
@github-actions github-actions bot temporarily deployed to storybook fix-crash-on-search-for-products-without-category October 23, 2020 11:08 Inactive
@github-actions github-actions bot temporarily deployed to fix-crash-on-search-for-products-without-category October 23, 2020 11:25 Inactive
@bmigirl bmigirl merged commit 1aaef80 into master Oct 23, 2020
@bmigirl bmigirl deleted the fix/crash-on-search-for-products-without-category branch October 23, 2020 11:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants